fix: have wildcard replace work in duckdb and snowflake syntax

sigmacomputing · Apr 17, 2024 · f90a446 · f90a446
1 parent 2f03fad
commit f90a446
Show file tree

Hide file tree

Showing 3 changed files with 51 additions and 1 deletion.
diff --git a/src/parser/mod.rs b/src/parser/mod.rs
@@ -9059,7 +9059,7 @@ impl<'a> Parser<'a> {
             None
         };
 
-        let opt_replace = if dialect_of!(self is GenericDialect | BigQueryDialect | ClickHouseDialect)
+        let opt_replace = if dialect_of!(self is GenericDialect | BigQueryDialect | ClickHouseDialect |  DuckDbDialect | SnowflakeDialect)
         {
             self.parse_optional_select_item_replace()?
         } else {

diff --git a/tests/sqlparser_duckdb.rs b/tests/sqlparser_duckdb.rs
@@ -508,3 +508,31 @@ fn test_duckdb_named_argument_function_with_assignment_operator() {
         expr_from_projection(only(&select.projection))
     );
 }
+
+#[test]
+fn test_select_wildcard_with_replace() {
+    let select = duckdb_and_generic()
+        .verified_only_select(r#"SELECT * REPLACE (lower(city) AS city) FROM addresses"#);
+    let expected = SelectItem::Wildcard(WildcardAdditionalOptions {
+        opt_replace: Some(ReplaceSelectItem {
+            items: vec![Box::new(ReplaceSelectElement {
+                expr: Expr::Function(Function {
+                    name: ObjectName(vec![Ident::new("lower")]),
+                    args: vec![FunctionArg::Unnamed(FunctionArgExpr::Expr(
+                        Expr::Identifier(Ident::new("city")),
+                    ))],
+                    filter: None,
+                    null_treatment: None,
+                    over: None,
+                    distinct: false,
+                    special: false,
+                    order_by: vec![],
+                }),
+                column_name: Ident::new("city"),
+                as_keyword: true,
+            })],
+        }),
+        ..Default::default()
+    });
+    assert_eq!(expected, select.projection[0]);
+}
diff --git a/tests/sqlparser_snowflake.rs b/tests/sqlparser_snowflake.rs
@@ -1554,3 +1554,25 @@ fn parse_comma_outer_join() {
 fn test_sf_trailing_commas() {
     snowflake().verified_only_select_with_canonical("SELECT 1, 2, FROM t", "SELECT 1, 2 FROM t");
 }
+
+#[test]
+fn test_select_wildcard_with_replace() {
+    let select = snowflake_and_generic().verified_only_select(
+        r#"SELECT * REPLACE ('DEPT-' || department_id AS department_id) FROM tbl"#,
+    );
+    let expected = SelectItem::Wildcard(WildcardAdditionalOptions {
+        opt_replace: Some(ReplaceSelectItem {
+            items: vec![Box::new(ReplaceSelectElement {
+                expr: Expr::BinaryOp {
+                    left: Box::new(Expr::Value(Value::SingleQuotedString("DEPT-".to_owned()))),
+                    op: BinaryOperator::StringConcat,
+                    right: Box::new(Expr::Identifier(Ident::new("department_id"))),
+                },
+                column_name: Ident::new("department_id"),
+                as_keyword: true,
+            })],
+        }),
+        ..Default::default()
+    });
+    assert_eq!(expected, select.projection[0]);
+}