Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Interaction API, to be replaced by Actions API #18

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

peternandersson
Copy link
Contributor

This PR removes the Interaction API, since we're intending on replacing this feature with the new Actions API in the next minor version release.

Pearce-Ropion
Pearce-Ropion previously approved these changes Sep 17, 2024
Copy link
Collaborator

@Pearce-Ropion Pearce-Ropion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a breaking change with a semver bump. We should release it with plugins.

@Pearce-Ropion
Copy link
Collaborator

Actually, can you change the base branch to the plugins branch?

@peternandersson
Copy link
Contributor Author

Actually, can you change the base branch to the plugins branch?

Which branch? The plugin-actions branch? The change shouldn't be breaking until we publish to npm unless I'm missing something, and we could release to 1.1.0 to avoid the issue or just deprecate the functionality instead of removing it altogether - I'd probably favor the former.

@peternandersson
Copy link
Contributor Author

Going to replace this with a deprecation warning instead of removing altogether, will re-request once the changes are pushed.

@peternandersson peternandersson changed the title Remove Interaction API, to be replaced by Actions API Deprecate Interaction API, to be replaced by Actions API Sep 19, 2024
@peternandersson peternandersson merged commit 17f331b into main Sep 19, 2024
1 check passed
@peternandersson peternandersson deleted the peter/remove-interaction-api branch September 19, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants