Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete trigger registration #11

Merged
merged 4 commits into from
Jul 9, 2024
Merged

Conversation

alisonjlai
Copy link
Contributor

@alisonjlai alisonjlai commented Jul 7, 2024

Corresponding change in Slate: https://github.com/sigmacomputing/slate/pull/35132

Before, trigger ID was the same as trigger name. With the corresponding change in Slate (https://github.com/sigmacomputing/slate/pull/35132), Slate will use genId to generate a new ID for each action-trigger in configOptions when the plugin initializes, and register/update plugin's config with the trigger ID.

@alisonjlai alisonjlai changed the title Add event listener for trigger ID registration Delete trigger registration Jul 8, 2024
@alisonjlai alisonjlai marked this pull request as ready for review July 8, 2024 18:40
@alisonjlai alisonjlai merged commit 9d8b2ec into plugin-actions Jul 9, 2024
1 check passed
@alisonjlai alisonjlai deleted the alison/register-listener branch July 9, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants