Refactor/types #83
Merged
Refactor/types #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spike-rabbit
approved these changes
Sep 26, 2024
chintankavathia
requested changes
Sep 26, 2024
projects/ngx-datatable/src/lib/components/body/body-row-wrapper.component.ts
Outdated
Show resolved
Hide resolved
timowolf
force-pushed
the
refactor/types
branch
2 times, most recently
from
4c42c9f
to
62c73c5
Compare
BREAKING CHANGE: Change signature from onBodyPage({ offset }: any): void to onBodyPage(offset: number): void
timowolf
force-pushed
the
refactor/types
branch
from
62c73c5
to
919d1d3
Compare
chintankavathia
approved these changes
Sep 26, 2024
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
I went through all types and moved them to internal or public file. This should help
to sharpen the API. Please review if this is correct.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: