refactor: remove unused code

siemens · Nov 7, 2024 · 13cd502 · 13cd502
1 parent 8746866
commit 13cd502
Show file tree

Hide file tree

Showing 31 changed files with 21 additions and 97 deletions.
diff --git a/projects/ngx-datatable/src/lib/components/body/body-cell.component.spec.ts b/projects/ngx-datatable/src/lib/components/body/body-cell.component.spec.ts
@@ -8,7 +8,6 @@ import { DataTableBodyCellComponent } from './body-cell.component';
 describe('DataTableBodyCellComponent', () => {
   let fixture: ComponentFixture<DataTableBodyCellComponent>;
   let component: DataTableBodyCellComponent;
-  let element;
 
   // provide our implementations or mocks to the dependency injector
   beforeEach(() => {
@@ -21,7 +20,6 @@ describe('DataTableBodyCellComponent', () => {
     TestBed.compileComponents().then(() => {
       fixture = TestBed.createComponent(DataTableBodyCellComponent);
       component = fixture.componentInstance;
-      element = fixture.nativeElement;
     });
   }));
 

diff --git a/projects/ngx-datatable/src/lib/components/body/body-group-header-template.directive.ts b/projects/ngx-datatable/src/lib/components/body/body-group-header-template.directive.ts
@@ -1,4 +1,4 @@
-import { Directive, TemplateRef } from '@angular/core';
+import { Directive } from '@angular/core';
 import { GroupContext } from '../../types/public.types';
 
 @Directive({

diff --git a/projects/ngx-datatable/src/lib/components/body/body-row-wrapper.component.spec.ts b/projects/ngx-datatable/src/lib/components/body/body-row-wrapper.component.spec.ts
@@ -1,31 +1,34 @@
 import { ComponentFixture, TestBed, waitForAsync } from '@angular/core/testing';
 import { DataTableRowWrapperComponent } from './body-row-wrapper.component';
+import { DatatableComponentToken } from '../../utils/table-token';
 
 describe('DataTableRowWrapperComponent', () => {
   let fixture: ComponentFixture<DataTableRowWrapperComponent>;
   let component: DataTableRowWrapperComponent;
-  let element;
 
   // provide our implementations or mocks to the dependency injector
   beforeEach(() => {
     TestBed.configureTestingModule({
-      declarations: [DataTableRowWrapperComponent]
+      declarations: [DataTableRowWrapperComponent],
+      providers: [
+        {
+          provide: DatatableComponentToken,
+          useValue: {}
+        }
+      ]
     });
   });
 
   beforeEach(waitForAsync(() => {
     TestBed.compileComponents().then(() => {
       fixture = TestBed.createComponent(DataTableRowWrapperComponent);
       component = fixture.componentInstance;
-      element = fixture.nativeElement;
     });
   }));
 
-  /*
   describe('fixture', () => {
     it('should have a component instance', () => {
       expect(component).toBeTruthy();
     });
   });
-  */
 });
diff --git a/projects/ngx-datatable/src/lib/components/body/body-row-wrapper.component.ts b/projects/ngx-datatable/src/lib/components/body/body-row-wrapper.component.ts
@@ -20,7 +20,6 @@ import {
   ViewChild
 } from '@angular/core';
 import { BehaviorSubject } from 'rxjs';
-import { NgStyle } from '@angular/common';
 import { DatatableComponentToken } from '../../utils/table-token';
 import { Group, GroupContext, RowDetailContext, RowOrGroup } from '../../types/public.types';
 import { DatatableGroupHeaderDirective } from './body-group-header.directive';

diff --git a/projects/ngx-datatable/src/lib/components/body/body-row.component.spec.ts b/projects/ngx-datatable/src/lib/components/body/body-row.component.spec.ts
@@ -5,7 +5,6 @@ import { DataTableBodyCellComponent } from './body-cell.component';
 describe('DataTableBodyRowComponent', () => {
   let fixture: ComponentFixture<DataTableBodyRowComponent>;
   let component: DataTableBodyRowComponent;
-  let element: any;
 
   // provide our implementations or mocks to the dependency injector
   beforeEach(() => {
@@ -18,15 +17,12 @@ describe('DataTableBodyRowComponent', () => {
     TestBed.compileComponents().then(() => {
       fixture = TestBed.createComponent(DataTableBodyRowComponent);
       component = fixture.componentInstance;
-      element = fixture.nativeElement;
     });
   }));
 
-  /*
   describe('fixture', () => {
     it('should have a component instance', () => {
       expect(component).toBeTruthy();
     });
   });
-  */
 });
diff --git a/projects/ngx-datatable/src/lib/components/body/body-row.component.ts b/projects/ngx-datatable/src/lib/components/body/body-row.component.ts
@@ -18,10 +18,8 @@ import {
 
 import { columnGroupWidths, columnsByPin, columnsByPinArr } from '../../utils/column';
 import { Keys } from '../../utils/keys';
-import { ScrollbarHelper } from '../../services/scrollbar-helper.service';
 import { BehaviorSubject } from 'rxjs';
 import { ActivateEvent, RowOrGroup, TreeStatus } from '../../types/public.types';
-import { NgStyle } from '@angular/common';
 import { TableColumn } from '../../types/table-column.type';
 import { ColumnGroupWidth, PinnedColumns } from '../../types/internal.types';
 
@@ -60,7 +58,6 @@ import { ColumnGroupWidth, PinnedColumns } from '../../types/internal.types';
   `
 })
 export class DataTableBodyRowComponent<TRow = any> implements DoCheck, OnChanges {
-  private scrollbarHelper = inject(ScrollbarHelper);
   private cd = inject(ChangeDetectorRef);
 
   @Input() set columns(val: TableColumn[]) {
@@ -157,11 +154,6 @@ export class DataTableBodyRowComponent<TRow = any> implements DoCheck, OnChanges
   _offsetX: number;
   _columns: TableColumn[];
   _innerWidth: number;
-  _groupStyles: {
-    left: NgStyle['ngStyle'];
-    center: NgStyle['ngStyle'];
-    right: NgStyle['ngStyle'];
-  } = { left: {}, center: {}, right: {} };
 
   private _rowDiffer: KeyValueDiffer<keyof RowOrGroup<TRow>, any> = inject(KeyValueDiffers)
     .find({})

diff --git a/projects/ngx-datatable/src/lib/components/body/body.component.spec.ts b/projects/ngx-datatable/src/lib/components/body/body.component.spec.ts
@@ -12,7 +12,6 @@ import { ScrollbarHelper } from '../../services/scrollbar-helper.service';
 describe('DataTableBodyComponent', () => {
   let fixture: ComponentFixture<DataTableBodyComponent>;
   let component: DataTableBodyComponent;
-  let element: any;
 
   // provide our implementations or mocks to the dependency injector
   beforeEach(() => {
@@ -35,7 +34,6 @@ describe('DataTableBodyComponent', () => {
     TestBed.compileComponents().then(() => {
       fixture = TestBed.createComponent(DataTableBodyComponent);
       component = fixture.componentInstance;
-      element = fixture.nativeElement;
     });
   }));
 

diff --git a/projects/ngx-datatable/src/lib/components/body/body.component.ts b/projects/ngx-datatable/src/lib/components/body/body.component.ts
@@ -584,13 +584,6 @@ export class DataTableBodyComponent<TRow extends { treeStatus?: TreeStatus } = a
     // parameters as group paging parameters ie if limit 10 has been
     // specified treat it as 10 groups rather than 10 rows
     if (this.groupedRows) {
-      let maxRowsPerGroup = 3;
-      // if there is only one group set the maximum number of
-      // rows per group the same as the total number of rows
-      if (this.groupedRows.length === 1) {
-        maxRowsPerGroup = this.groupedRows[0].value.length;
-      }
-
       while (rowIndex < last && rowIndex < this.groupedRows.length) {
         // Add the groups into this page
         const group = this.groupedRows[rowIndex];
@@ -767,13 +760,6 @@ export class DataTableBodyComponent<TRow extends { treeStatus?: TreeStatus } = a
     };
   });
 
-  /**
-   * Hides the loading indicator
-   */
-  hideIndicator(): void {
-    setTimeout(() => (this.loadingIndicator = false), 500);
-  }
-
   /**
    * Updates the index of the rows in the viewport
    */
@@ -931,13 +917,6 @@ export class DataTableBodyComponent<TRow extends { treeStatus?: TreeStatus } = a
     this.updateIndexes();
   }
 
-  /**
-   * Tracks the column
-   */
-  columnTrackingFn(index: number, column: any): any {
-    return column.$$id;
-  }
-
   /**
    * Returns if the row was expanded and set default row expansion when row expansion is empty
    */

diff --git a/projects/ngx-datatable/src/lib/components/body/ghost-loader/ghost-loader.component.spec.ts b/projects/ngx-datatable/src/lib/components/body/ghost-loader/ghost-loader.component.spec.ts
@@ -4,7 +4,6 @@ import { DataTableGhostLoaderComponent } from './ghost-loader.component';
 describe('DataTableGhostLoaderComponent', () => {
   let fixture: ComponentFixture<DataTableGhostLoaderComponent>;
   let component: DataTableGhostLoaderComponent;
-  let element;
 
   // provide our implementations or mocks to the dependency injector
   beforeEach(() => {
@@ -17,7 +16,6 @@ describe('DataTableGhostLoaderComponent', () => {
     TestBed.compileComponents().then(() => {
       fixture = TestBed.createComponent(DataTableGhostLoaderComponent);
       component = fixture.componentInstance;
-      element = fixture.nativeElement;
     });
   }));
 

diff --git a/projects/ngx-datatable/src/lib/components/body/progress-bar.component.spec.ts b/projects/ngx-datatable/src/lib/components/body/progress-bar.component.spec.ts
@@ -4,7 +4,6 @@ import { ProgressBarComponent } from './progress-bar.component';
 describe('ProgressBarComponent', () => {
   let fixture: ComponentFixture<ProgressBarComponent>;
   let component: ProgressBarComponent;
-  let element;
 
   // provide our implementations or mocks to the dependency injector
   beforeEach(() => {
@@ -17,7 +16,6 @@ describe('ProgressBarComponent', () => {
     TestBed.compileComponents().then(() => {
       fixture = TestBed.createComponent(ProgressBarComponent);
       component = fixture.componentInstance;
-      element = fixture.nativeElement;
     });
   }));
 

diff --git a/projects/ngx-datatable/src/lib/components/body/scroller.component.spec.ts b/projects/ngx-datatable/src/lib/components/body/scroller.component.spec.ts
@@ -4,7 +4,6 @@ import { ScrollerComponent } from './scroller.component';
 describe('ScrollerComponent', () => {
   let fixture: ComponentFixture<ScrollerComponent>;
   let component: ScrollerComponent;
-  let element;
 
   // provide our implementations or mocks to the dependency injector
   beforeEach(() => {
@@ -17,7 +16,6 @@ describe('ScrollerComponent', () => {
     TestBed.compileComponents().then(() => {
       fixture = TestBed.createComponent(ScrollerComponent);
       component = fixture.componentInstance;
-      element = fixture.nativeElement;
     });
   }));
 

diff --git a/projects/ngx-datatable/src/lib/components/body/scroller.component.ts b/projects/ngx-datatable/src/lib/components/body/scroller.component.ts
@@ -6,7 +6,6 @@ import {
   HostBinding,
   inject,
   Input,
-  NgZone,
   OnDestroy,
   OnInit,
   Output,

diff --git a/projects/ngx-datatable/src/lib/components/body/selection.component.spec.ts b/projects/ngx-datatable/src/lib/components/body/selection.component.spec.ts
@@ -4,7 +4,6 @@ import { DataTableSelectionComponent } from './selection.component';
 describe('DataTableSelectionComponent', () => {
   let fixture: ComponentFixture<DataTableSelectionComponent>;
   let component: DataTableSelectionComponent;
-  let element;
 
   // provide our implementations or mocks to the dependency injector
   beforeEach(() => {
@@ -17,7 +16,6 @@ describe('DataTableSelectionComponent', () => {
     TestBed.compileComponents().then(() => {
       fixture = TestBed.createComponent(DataTableSelectionComponent);
       component = fixture.componentInstance;
-      element = fixture.nativeElement;
     });
   }));
 

diff --git a/projects/ngx-datatable/src/lib/components/body/summary/summary-row.component.spec.ts b/projects/ngx-datatable/src/lib/components/body/summary/summary-row.component.spec.ts
@@ -1,5 +1,5 @@
 import { ComponentFixture, TestBed, waitForAsync } from '@angular/core/testing';
-import { DebugElement, PipeTransform } from '@angular/core';
+import { DebugElement } from '@angular/core';
 import { By } from '@angular/platform-browser';
 
 import { DataTableBodyRowComponent } from '../body-row.component';

diff --git a/projects/ngx-datatable/src/lib/components/columns/column-ghost-cell.directive.ts b/projects/ngx-datatable/src/lib/components/columns/column-ghost-cell.directive.ts
@@ -1,4 +1,4 @@
-import { Directive, TemplateRef } from '@angular/core';
+import { Directive } from '@angular/core';
 
 @Directive({ selector: '[ngx-datatable-ghost-cell-template]' })
 export class DataTableColumnGhostCellDirective {

diff --git a/projects/ngx-datatable/src/lib/components/columns/column.directive.spec.ts b/projects/ngx-datatable/src/lib/components/columns/column.directive.spec.ts
@@ -22,7 +22,6 @@ class TestFixtureComponent {
 describe('DataTableColumnDirective', () => {
   let fixture: ComponentFixture<TestFixtureComponent>;
   let component: TestFixtureComponent;
-  let element;
 
   // provide our implementations or mocks to the dependency injector
   beforeEach(() => {
@@ -43,7 +42,6 @@ describe('DataTableColumnDirective', () => {
     TestBed.compileComponents().then(() => {
       fixture = TestBed.createComponent(TestFixtureComponent);
       component = fixture.componentInstance;
-      element = fixture.nativeElement;
     });
   }));
 

diff --git a/projects/ngx-datatable/src/lib/components/footer/pager.component.spec.ts b/projects/ngx-datatable/src/lib/components/footer/pager.component.spec.ts
@@ -5,7 +5,6 @@ import { DataTablePagerComponent } from './pager.component';
 describe('DataTablePagerComponent', () => {
   let fixture;
   let pager: DataTablePagerComponent;
-  let element;
 
   // provide our implementations or mocks to the dependency injector
   beforeEach(() =>
@@ -19,7 +18,6 @@ describe('DataTablePagerComponent', () => {
 
     fixture = TestBed.createComponent(DataTablePagerComponent);
     pager = fixture.componentInstance;
-    element = fixture.nativeElement;
   }));
 
   describe('size', () => {

diff --git a/projects/ngx-datatable/src/lib/components/header/header-cell.component.spec.ts b/projects/ngx-datatable/src/lib/components/header/header-cell.component.spec.ts
@@ -4,7 +4,6 @@ import { DataTableHeaderCellComponent } from './header-cell.component';
 describe('DataTableHeaderCellComponent', () => {
   let fixture: ComponentFixture<DataTableHeaderCellComponent>;
   let component: DataTableHeaderCellComponent;
-  let element: any;
 
   // provide our implementations or mocks to the dependency injector
   beforeEach(() => {
@@ -17,7 +16,6 @@ describe('DataTableHeaderCellComponent', () => {
     TestBed.compileComponents().then(() => {
       fixture = TestBed.createComponent(DataTableHeaderCellComponent);
       component = fixture.componentInstance;
-      element = fixture.nativeElement;
     });
   }));
 

diff --git a/projects/ngx-datatable/src/lib/components/row-detail/row-detail-template.directive.ts b/projects/ngx-datatable/src/lib/components/row-detail/row-detail-template.directive.ts
@@ -1,4 +1,4 @@
-import { Directive, TemplateRef } from '@angular/core';
+import { Directive } from '@angular/core';
 import { RowDetailContext } from '../../types/public.types';
 
 @Directive({

diff --git a/projects/ngx-datatable/src/lib/components/row-detail/row-detail.directive.spec.ts b/projects/ngx-datatable/src/lib/components/row-detail/row-detail.directive.spec.ts
@@ -18,7 +18,6 @@ class TestFixtureComponent {}
 describe('DatatableRowDetailDirective', () => {
   let fixture: ComponentFixture<TestFixtureComponent>;
   let component: TestFixtureComponent;
-  let element;
 
   // provide our implementations or mocks to the dependency injector
   beforeEach(() => {
@@ -35,7 +34,6 @@ describe('DatatableRowDetailDirective', () => {
     TestBed.compileComponents().then(() => {
       fixture = TestBed.createComponent(TestFixtureComponent);
       component = fixture.componentInstance;
-      element = fixture.nativeElement;
     });
   }));
 

diff --git a/projects/ngx-datatable/src/lib/directives/disable-row.directive.ts b/projects/ngx-datatable/src/lib/directives/disable-row.directive.ts
@@ -1,11 +1,4 @@
-import {
-  AfterContentInit,
-  booleanAttribute,
-  Directive,
-  ElementRef,
-  inject,
-  Input
-} from '@angular/core';
+import { booleanAttribute, Directive, ElementRef, inject, Input } from '@angular/core';
 
 /**
  * Row Disable Directive

diff --git a/projects/ngx-datatable/src/lib/directives/long-press.directive.spec.ts b/projects/ngx-datatable/src/lib/directives/long-press.directive.spec.ts
@@ -1,4 +1,4 @@
-import { ComponentFixture, fakeAsync, TestBed, tick, waitForAsync } from '@angular/core/testing';
+import { ComponentFixture, TestBed, waitForAsync } from '@angular/core/testing';
 import { Component } from '@angular/core';
 import { By } from '@angular/platform-browser';
 import { LongPressDirective } from './long-press.directive';
@@ -12,7 +12,6 @@ class TestFixtureComponent {}
 describe('LongPressDirective', () => {
   let fixture: ComponentFixture<TestFixtureComponent>;
   let component: TestFixtureComponent;
-  let element;
 
   // provide our implementations or mocks to the dependency injector
   beforeEach(() => {
@@ -25,7 +24,6 @@ describe('LongPressDirective', () => {
     TestBed.compileComponents().then(() => {
       fixture = TestBed.createComponent(TestFixtureComponent);
       component = fixture.componentInstance;
-      element = fixture.nativeElement;
     });
   }));
 

diff --git a/projects/ngx-datatable/src/lib/directives/long-press.directive.ts b/projects/ngx-datatable/src/lib/directives/long-press.directive.ts
@@ -9,9 +9,8 @@ import {
   OnDestroy,
   Output
 } from '@angular/core';
-import { fromEvent, Observable, Subscription } from 'rxjs';
+import { fromEvent, Subscription } from 'rxjs';
 import { takeUntil } from 'rxjs/operators';
-import { MouseEvent } from '../events';
 import { TableColumn } from '../types/table-column.type';
 
 @Directive({ selector: '[long-press]' })