Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single-shot solving benchmarks implementation #56

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

Single-shot solving benchmarks implementation #56

wants to merge 15 commits into from

Conversation

Kriplingo
Copy link
Collaborator

Created a subdirectory for single-shot benchmarking with adjusted encodings and automated single-shot benchmarking script.

rtaupe
rtaupe requested changes Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@rtaupe rtaupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please suggest a reorganization of the directory structure in which the current contents of the singleshot_bench directory are in a subdirectory of benchmarks.
And then let's do a peer review of your pull request face-to-face.
Thank you!

rtaupe
rtaupe requested changes Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@rtaupe rtaupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the below comments and separate the generation of BM instances and the running of the BMs into two separate scripts. Thank you!

benchmarks/singleshot/README.md Show resolved Hide resolved
benchmarks/singleshot/autorun.py Outdated
ELEMENT_TYPES = 4
ELEMENT_NAMES = 'ABCD'

domain_sizes = [19, 33, 51, 65, 84, 98, 116, 130, 149, 163, 181, 195, 214, 228, 246, 260, 279, 293, 311, 325]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some documentation

benchmarks/singleshot/autorun.py Show resolved Hide resolved
benchmarks/singleshot/autorun.py Outdated Show resolved Hide resolved
benchmarks/singleshot/autorun.py Outdated Show resolved Hide resolved
benchmarks/singleshot/ooasp_guess.lp Outdated Show resolved Hide resolved
benchmarks/singleshot/singleshot.lp
@@ -0,0 +1,9 @@
#include "ooasp.lp".
#include "ooasp_symmetry.lp".
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For better comparability, please keep #include statements that already exist in ooasp.lp there, and only add includes here that do not exist in the multi-shot version of ooasp.lp

benchmarks/singleshot/ooasp.lp
Comment on lines +30 to +31
:- user(ooasp_isa(C,new_object)),
not ooasp_isa(C,new_object).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be removed

benchmarks/singleshot/ooasp_cautious.opt.lp Outdated
@@ -0,0 +1,23 @@
% Copyright (c) 2022 Siemens AG Oesterreich
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File not used (?), please remove

benchmarks/singleshot/racks/constraints.lp Outdated Show resolved Hide resolved
@rtaupe rtaupe marked this pull request as draft August 13, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtaupe rtaupe rtaupe requested changes

@gschennersie gschennersie Awaiting requested review from gschennersie gschennersie is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kriplingo @rtaupe