v9.3.9

.appveyor.yml

@@ -20,7 +20,7 @@ init:
 
 install:
   - cmd: echo 🔧 Setting up Node
-  - ps: Update-NodeJsInstallation 12.6.0
+  - ps: Update-NodeJsInstallation 12.7.0
   - cmd: npm --global update npm
   - cmd: npm --global install yarn
 

.travis.yml

@@ -1,8 +1,8 @@
 matrix:
   include:
     - os: linux
+      dist: xenial
       sudo: required
-      dist: trusty
       group: edge
       compiler: clang
 
@@ -36,7 +36,7 @@ env:
 before_install:
   - echo "🔧 Setting up Node"
   - curl -o- https://raw.githubusercontent.com/creationix/nvm/master/install.sh | NVM_DIR="${HOME}"/.nvm sh
-  - source "${HOME}"/.nvm/nvm.sh && nvm install 12.6.0 && nvm use 12.6.0
+  - source "${HOME}"/.nvm/nvm.sh && nvm install 12.7.0 && nvm use 12.7.0
   - npm --global update npm
   - npm --global install yarn
 

RELEASENOTES.json

@@ -1,4 +1,30 @@
 {
+  "9.3.9": {
+    "🍾 features": [
+      "adds `msi` installer package (Windows)",
+      "adds portable application package (Windows)"
+    ],
+      "🚨 fixes": [
+        "fixes multiple isses regarding application auto updates"
+    ],
+    "👷 internals": [
+      "upgrades internal `node_modules`",
+      "upgrades external `node_modules`"
+    ]
+  },
+  "9.1.1": {
+    "💎 improvements": [
+      "various stability and performance improvements"
+    ],
+      "🚨 fixes": [
+        "migrates `electron` APIs to v6.0.0"
+    ],
+    "👷 internals": [
+      "upgrades `electron` to `v6.0.0`",
+      "upgrades internal `node_modules`",
+      "upgrades external `node_modules`"
+    ]
+  },
   "9.0.9": {
     "🍾 features": [
       "adds file-based `Notification Filter` for hiding notifications via text or regular expression pattern (https://github.com/sidneys/pb-for-desktop/issues/76)"

app/scripts/main/menus/app-menu.js

@@ -214,13 +214,13 @@ let getAppMenuTemplate = () => {
                     type: 'separator'
                 },
                 {
-                    label: `Open Log...`,
+                    label: `Show Logfile...`,
                     click() {
-                        shell.openItem(logFilePath)
+                        shell.showItemInFolder(logFilePath)
                     }
                 },
                 {
-                    label: `Restart in Developer Mode...`,
+                    label: `Restart in Debugging Mode...`,
                     click() {
                         app.relaunch({ args: process.argv.slice(1).concat([ '--debug' ]) })
                         app.quit()

app/scripts/main/menus/tray-menu.js

@@ -23,6 +23,7 @@ const { app, ipcMain, Menu, MenuItem, shell, Tray, webContents } = require('elec
  */
 const appRootPath = require('app-root-path')['path']
 const dialogProvider = require('@sidneys/electron-dialog-provider')
+const electronUpdaterService = require('@sidneys/electron-updater-service')
 const isDebug = require('@sidneys/is-env')('debug')
 const logger = require('@sidneys/logger')({ write: true })
 const platformTools = require('@sidneys/platform-tools')
@@ -133,6 +134,15 @@ let createTrayMenuTemplate = () => {
                 configurationManager('appAutoUpdate').set(menuItem.checked)
             }
         },
+        {
+            id: 'simulateAppUpdate',
+            label: 'Simulate App Update...',
+            type: 'normal',
+            visible: process.defaultApp || isDebug,
+            click(menuItem) {
+                electronUpdaterService.simulate()
+            }
+        },
         {
             type: 'separator'
         },
@@ -142,9 +152,16 @@ let createTrayMenuTemplate = () => {
             icon: trayMenuItemImageReset,
             type: 'normal',
             click() {
-                dialogProvider.question('Are you sure you want to reset?',
+                dialogProvider.showConfirmation('Are you sure you want to reset?',
                     `${appProductName} will reset to its initial state.${os.EOL}Unsaved changes will be lost.`,
-                    (result) => {
+                    (error, result) => {
+                        // Handle Error
+                        if (error) {
+                            logger.error('reset', 'dialogProvider.showConfirmation', error)
+                            return
+                        }
+
+                        // Handle Result
                         if (result === 0) {
                             configurationManager('appLaunchOnStartup').set(configurationManager('appLaunchOnStartup').default)
                             configurationManager('appShowBadgeCount').set(configurationManager('appShowBadgeCount').default)
@@ -164,7 +181,10 @@ let createTrayMenuTemplate = () => {
                             })
 
                             sessionList.forEach((session, sessionIndex) => {
-                                if (!session.clearCache) { return }
+                                if (!session.clearCache) {
+                                    return
+                                }
+
                                 session.clearCache(() => {
                                     session.clearStorageData({
                                         storages: [ 'appcache', 'cookies', 'filesystem', 'indexdb', 'localstorage', 'serviceworkers', 'shadercache', 'websql' ],
@@ -189,15 +209,23 @@ let createTrayMenuTemplate = () => {
             icon: trayMenuItemImageReconnect,
             type: 'normal',
             click() {
-                dialogProvider.question('Are you sure you want to reconnect to Pushbullet?',
+                dialogProvider.showConfirmation('Are you sure you want to reconnect to Pushbullet?',
                     `${appProductName} will reconnect to Pushbullet.${os.EOL}` +
                     `All unsaved changes will be lost.`,
-                    (result) => {
-                        if (result === 0) {
+                    (error, result) => {
+                        // Handle Error
+                        if (error) {
+                            logger.error('reconnect', 'dialogProvider.showConfirmation', error)
+                            return
+                        }
+
+                        // Handle Result
+                        if (result === 1) {
                             logger.log('reconnect', 'relaunching')
 
                             app.relaunch()
                             app.quit()
+                            return
                         }
                     })
             }
@@ -324,13 +352,20 @@ let createTrayMenuTemplate = () => {
             type: 'normal',
             click() {
                 app.focus()
-                dialogProvider.file('Open Sound File (.m4a, .mp3, .mp4, .ogg, .wav)', [ 'm4a', 'mp3', 'mp4', 'wav', 'ogg' ], appSoundDirectory, (error, soundFile) => {
-                    if (error) {
-                        logger.error('pushbulletSoundFilePath', 'dialogProvider.file', error)
-                        return
-                    }
+                dialogProvider.openFile(
+                    'Open Sound File (.m4a, .mp3, .mp4, .ogg, .wav)',
+                    [ 'm4a', 'mp3', 'mp4', 'wav', 'ogg' ],
+                    appSoundDirectory,
+                    (error, filePath) => {
+                        // Handle Error
+                        if (error) {
+                            logger.error('pushbulletSoundFilePath', 'dialogProvider.openFile', error)
+
+                            return
+                        }
 
-                    configurationManager('pushbulletSoundFilePath').set(soundFile)
+                        // Handle Result
+                        configurationManager('pushbulletSoundFilePath').set(filePath)
                 })
             }
         },
@@ -395,7 +430,8 @@ let createTrayMenuTemplate = () => {
         },
         {
             id: 'showTestNotification',
-            label: 'Show Test Notification',
+            label: 'Show Test Notification...',
+            type: 'normal',
             click() {
                 const notification = notificationProvider.create({
                     body: 'This is a test notification.',

app/scripts/main/windows/main-window.js

@@ -78,11 +78,14 @@ class MainWindow {
             webPreferences: {
                 allowRunningInsecureContent: true,
                 backgroundThrottling: false,
-                experimentalCanvasFeatures: true,
+                contextIsolation: false,
+                experimentalFeatures: true,
                 experimentalFeatures: true,
                 nodeIntegration: true,
+                nodeIntegrationInSubFrames: true,
                 nodeIntegrationInWorker: true,
                 partition: 'persist:app',
+                sandbox: false,
                 scrollBounce: platformTools.isMacOS ? true : void 0,
                 webaudio: true,
                 webgl: true,

app/scripts/renderer/pushbullet/push.js

@@ -40,7 +40,7 @@ const moment = require('moment')
 const notificationProvider = remote.require('@sidneys/electron-notification-provider')
 const opn = require('opn')
 const shortid = require('shortid')
-const throttledQueue = require('throttled-queue')
+const dynamicThrottledQueue = require('dynamic-throttled-queue')
 const _ = require('lodash')
 
 
@@ -80,22 +80,16 @@ const youtubeThumbnailEndpoint = 'https://img.youtube.com/vi/'
 
 
 /**
- * Notification Defaults
+ * Notification Defaults & Globals
  * @constant
  * @default
  * @global
  */
-const notificationDisplayInterval = 2000
+const notificationDisplayInterval = 1000
 const notificationIconWidth = 88
 const notificationFilterCommentTag = '//'
 const notificationFilterDebugPrefix = '[FILTERED]'
-
-/**
- * Notification Globals
- * @constant
- * @global
- */
-const notificationQueue = throttledQueue(1, notificationDisplayInterval, true)
+const notificationQueue = dynamicThrottledQueue({ min_rpi: 1, interval: notificationDisplayInterval, evenly_spaced: true })
 
 
 /**

app/scripts/renderer/webviews/pushbullet-webview.js

@@ -277,7 +277,7 @@ let addWebsocketEventHandlers = () => {
         if (!(pb && pb.ws && pb.ws.socket)) { return }
 
         pb.ws.socket.addEventListener('message', (ev) => {
-            logger.debug('pb.ws.socket#message')
+            // logger.debug('pb.ws.socket#message')
 
             let message
 
@@ -288,6 +288,8 @@ let addWebsocketEventHandlers = () => {
                 return
             }
 
+            logger.debug('pb.ws.socket#message', 'type:', message.type)
+
             if (message.type !== 'push') { return }
 
             /**