Skip to content

Commit

Permalink
v8.8.8
Browse files Browse the repository at this point in the history
  • Loading branch information
sidneys committed Feb 17, 2019
1 parent 139268a commit 63882c3
Show file tree
Hide file tree
Showing 10 changed files with 1,410 additions and 1,202 deletions.
2 changes: 1 addition & 1 deletion .appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ init:

install:
- cmd: echo 🔧 Setting up Node
- ps: Install-Product node 11.0.0
- ps: Install-Product node 11.9.0
- cmd: npm --global update npm
- cmd: npm --global install yarn

Expand Down
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ before_install:
- echo "🚦 Authorizing Build"
- echo "🔧 Setting up Node"
- curl -o- https://raw.githubusercontent.com/creationix/nvm/master/install.sh | NVM_DIR="${HOME}"/.nvm sh
- source "${HOME}"/.nvm/nvm.sh && nvm install 11.0.0 && nvm use 11.0.0
- source "${HOME}"/.nvm/nvm.sh && nvm install 11.9.0 && nvm use 11.9.0
- npm --global update npm
- npm --global install yarn

Expand Down
15 changes: 15 additions & 0 deletions RELEASENOTES.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,19 @@
{
"8.8.8": {
"🚨 fixes": [
"fixes intermittent rendering of Dock Icon Count badge when disabled ",
"fixes upstream issue: input cursor invisible after navigation in webview (https://github.com/electron/electron/issues/14474)"
],
"💎 improvements": [
"various stability and performance improvements"
],
"👷 internals": [
"upgrades `electron` to `v4.0.5`",
"upgrades `node_modules`",
"upgrades `services`",
"upgrades `lib`"
]
},
"8.6.0": {
"🍾 features": [
"Adds In-Line Reply (Notification actions) to Pushbullet Chats (macOS)",
Expand Down
4 changes: 2 additions & 2 deletions app/scripts/main/managers/configuration-manager.js
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ let configurationItems = {
implement(value) {
logger.debug(this.keypath, 'implement', value)

if (!!value === false) {
if (!value) {
app.setBadgeCount(0)
}
}
Expand Down Expand Up @@ -461,7 +461,7 @@ let configurationItems = {
*/
pushbulletRepeatRecentNotifications: {
keypath: 'pushbulletRepeatRecentNotifications',
default: true,
default: false,
init() {
logger.debug(this.keypath, 'init')
},
Expand Down
8 changes: 8 additions & 0 deletions app/scripts/renderer/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,14 @@ webviewViewElement.addEventListener('dom-ready', () => {
logger.debug('webviewViewElement#dom-ready')

domTools.injectCSS(webviewViewElement, stylesheetFilepath)

/**
* HOTFIX
* Input cursor invisible after navigation in webview
* @see {@link https://github.com/electron/electron/issues/14474}
*/
webviewViewElement.blur()
webviewViewElement.focus()
})

/** @namespace event.args */
Expand Down
3 changes: 1 addition & 2 deletions app/scripts/renderer/pushbullet/push.js
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,7 @@ let retrievePushbulletSoundVolume = () => configurationManager('pushbulletSoundV
let updateBadge = (total) => {
logger.debug('updateBadge')

const appShowBadgeCount = retrieveAppShowBadgeCount()
if (!!appShowBadgeCount) { return }
if (!retrieveAppShowBadgeCount()) { return }

remote.app.setBadgeCount(total)
}
Expand Down
Loading

0 comments on commit 63882c3

Please sign in to comment.