Merge pull request datajoint#25 from kushalbakshi/main

Fix error in `FacialSignal` `make()`
sidhulyalkar · Oct 18, 2023 · 4195dc0 · 4195dc0
2 parents 10550ad + 0f7b728
commit 4195dc0
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,10 @@
 Observes [Semantic Versioning](https://semver.org/spec/v2.0.0.html) standard and
 [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) convention.
 
+## [0.1.7] - 2023-10-18
+
++ Fix - Index `mot_Sv` and `movSv` by `roi_no` in `FacialSignal` 
+
 ## [0.1.6] - 2023-05-22
 
 + Add - Facemap citation

diff --git a/element_facemap/facial_behavior_estimation.py b/element_facemap/facial_behavior_estimation.py
@@ -463,7 +463,9 @@ def make(self, key):
                     key,
                     roi_no=roi_no,
                     pc_no=i,
-                    singular_value=dataset["motSv"][i] if "motSv" in dataset else None,
+                    singular_value=dataset["motSv"][roi_no][i]
+                    if "motSv" in dataset
+                    else None,
                     motmask=dataset["motMask_reshape"][roi_no + 1][:, :, i],
                     projection=dataset["motSVD"][roi_no + 1][i],
                 )
@@ -479,7 +481,9 @@ def make(self, key):
                     key,
                     roi_no=roi_no,
                     pc_no=i,
-                    singular_value=dataset["movSv"][i] if "movSv" in dataset else None,
+                    singular_value=dataset["movSv"][roi_no][i]
+                    if "movSv" in dataset
+                    else None,
                     movmask=dataset["movMask_reshape"][roi_no + 1][:, :, i],
                     projection=dataset["movSVD"][roi_no + 1][i],
                 )

diff --git a/element_facemap/version.py b/element_facemap/version.py
@@ -1,2 +1,2 @@
 """Package metadata."""
-__version__ = "0.1.6"
+__version__ = "0.1.7"