This repository has been archived by the owner on Sep 27, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there's a typo in the helper function
CellId.uv_to_st
in the case thatCellId.PROJECTION == 1
(the tangent projection). To wit: this should be an increasing function that maps[-1, 1]
to[0, 1]
, and in the default case it does. For example:However, if we use the tangent projection, this isn't the case:
I think this PR resolves the issue. Indeed, this function now matches the analogous function in the original C++ library.
This change is