-
Notifications
You must be signed in to change notification settings - Fork 13
Add simplified docker support #19
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -13,6 +13,6 @@ server { | |||
|
|||
# proxy the /api to connect to the API server: | |||
location /api { | |||
proxy_pass http://swl-api-server-web:8000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this isn't visible in Dockerland, but it is visible when this Docker image is deployed on our Kubernetes cluster (where oldto is hosted). We haven't open sourced this API server (yet!) which admittedly makes this a bit confusing. For local development, api.sidewalklabs.com or at an instance of the local dev server (oldtoronto/devserver.py
) are good alternatives.
We might want to pass the location of this server in via an environment variable or flag so that we can distinguish "in production" and "local development" more easily.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah man, that sounds good. Maybe based on a check that y'all have in prod, it could just add an /etc/hosts entry? Just chose api.sidewalklabs.com as a quick fix for now. Happy to riff later
@danvk alpine gets pretty small :)
(base image is only 4MB, and node image was 220MB before) |
Hi! not sure if this aligns with your vision, but just wanted to put it forward, since the dockerfile has a few bumps as-is.
I'm not often a docker user, but given all the ways this repo is used -- api, frontend, processing -- thought it might be helpful :)