-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: support debug shell for advanced development #9201
Conversation
b846292
to
6e78657
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall good, will rebase eudev stuff on top of this and try looking further
@frezbo Won't you mind if I push subsequent changes I do to this PR and finalize it to be merged? It helps debugging udev+selinux, so might help us in the future as well. Thanks for implementing this feature! |
👍 |
343988b
to
29b4a7f
Compare
5867c99
to
9ffbff5
Compare
@frezbo could you please take a look at my changes? |
@@ -87,6 +90,14 @@ func Switch(prefix string, mountpoints *mount.Points) (err error) { | |||
log.Printf("race detection enabled with halt_on_error=1") | |||
} | |||
|
|||
if val := procfs.ProcCmdline().Get("talos.debugshell"); val != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smira should we document this in kernel args?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🆒 👍
We might document in developing talos maybe, I can't approve my own PR
yes, it'd be nice to add it here: https://www.talos.dev/v1.9/advanced/developing-talos/ |
Should I do it right in this PR? |
yep, so that it is complete |
3694df6
to
e6ce9be
Compare
Support dropping into a very minimal debug shell. ```bash sudo -E --preserve-env=HOME _out/talosctl-linux-amd64 cluster create --provisioner=qemu $REGISTRY_MIRROR_FLAGS --controlplanes=1 --workers=0 --with-bootloader=false --with-debug-shell ``` Co-authored-by: Dmitry Sharshakov <[email protected]> Signed-off-by: Noel Georgi <[email protected]> Signed-off-by: Dmitry Sharshakov <[email protected]>
e6ce9be
to
1b22df4
Compare
/m |
Support dropping into a very minimal debug shell.
sudo -E --preserve-env=HOME _out/talosctl-linux-amd64 cluster create --provisioner=qemu $REGISTRY_MIRROR_FLAGS --controlplanes=1 --workers=0 --with-bootloader=false --with-debug-shell