Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the provided mimetype in B2FileList.upload #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Katharine
Copy link

The value passed for mime_content_type to B2FileList.upload was being discarded, leaving filename-based autodetection on in all cases.

Change upload to pass the mimetype through to the connector (which then handles it correctly).

@Katharine Katharine force-pushed the fix-upload-mimetype branch from 8a29346 to ac70185 Compare January 15, 2019 05:42
@sibblegp
Copy link
Owner

What happens if mime_content_type is None? Will it auto detect it?

@Katharine
Copy link
Author

Yes — in that case the connector code defaults to b2/x-auto, which guesses from the file extension.

@sibblegp
Copy link
Owner

sibblegp commented Oct 10, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants