Dynamic Legend: Fix for Rickshaw GitHub Issue #89 #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Re-factored Rickshaw.Graph.Legend considerably to allow for dynamic series additions/deletions. - Removed somewhat brittle "series-reordering" code in Rickshaw.Behavior.Series.Highlight and added the concept of zOrder to the Renderer.
- Legend order had been reversed from previous version. Fixed. - Rickshaw.Graph.Behavior.Series.Order.js interactions with the Legend were broken. Fixed.
… series at a time. This properly exercises the dynamic nature of the legend and the series behaviors.
|
I will mention that I attempted to use pull request #201 prior to embarking on this set of changes… Unfortunately it did not fix the issue for all edge cases and all of the current extensions. |
|
Thanks -- this is a good problem to solve. We have a branch around that aims to address some of these same issues. I'll take a pass through each and pull this together. |
|
How is the dynamic series branch doing, btw? It probably needs some work being rebased to current master, is that worth a shot? @dchester, do you remember what issues you had with the work so far and what needs to be done to get that branch and/or this PR merged? |
|
Probably should have that discussion on #341.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes up the Legend class so that it can properly respond to series that are being dynamically added/removed. I modified the extensions.html example so that it (quickly) adds the series one at a time to the graph. This will hopefully expose any non-dynamic problems in the future.
Tests conducted: