Add failure description (from errno) when failing to open device #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe I should throw an FileOpenError instead?
|
I need to rework the error reporting out of the open() methods in the SerialPort classes so as not to expose higher level code to its implementation. I'm thinking either an exception or a last error cause method. |
LumitoLuma
added a commit
to LumitoLuma/BOSSA
that referenced
this pull request
Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe I should throw an FileOpenError instead? Anyway, not having this error message cost me 30 minutes today and I don't want anyone else feel as stupid as I did when I noticed it was a permission problem.