Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvements to UI features of WriteTank #32

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kramester
Copy link

@kramester kramester commented Nov 15, 2018

  • created nuke autolabel that displays node name, file output, profile name, render order, and user label
  • removed the hijack of the user label; now the user can set their own label
  • renamed the menu entries to "sgWrite: profile" so they are easier to find with tab search
  • renamed the gizmos main tab to match the name of the gizmo: sgWrite
  • added the "name" knob to the gizmo and called it "sgWrite1". Using this convention, nuke will auto-increment the number of the node
  • removed the code that overrrides the node name and auto-increments in favor of the more nuke-centric approach above
  • removed the "1" from the Input1 node so that nuke no longer displays a "1" on the gizmo input

Anthony Kramer and others added 4 commits November 14, 2018 11:17
- created nuke autolabel that displays node name, file output, profile name, render order, and user label
- removed the hijack of the user label; now the user can set their own label
- renamed the menu entries to "sgWrite: profile" so they are easier to find with tab search
- added the "name" knob to the gizmo so that nuke names and auto-increments new nodes
- renamed the gizmos main tab to match the name of the gizmo: sgWrite
- removed the code that overrrides the node name and auto-increments in favor of the more nuke-centric approach
- removed the "1" from the Input1 node so that nuke no longer displays a "1" on the gizmo input
merging the latest shotgun software master into our chicken-bone master
#print ("sx:", scale_x, "sy:", scale_y, "tx:", offset_x, "ty:", offset_y,

#print ("sx:", scale_x, "sy:", scale_y, "tx:", offset_x, "ty:", offset_y,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

block comment should start with '# '

path_warning += ("   "
+ " <br>&nbsp;&nbsp;&nbsp;".join(self.__wrap_text(str(e), 57))
path_warning += ("&nbsp;&nbsp;&nbsp;"
+ " <br>&nbsp;&nbsp;&nbsp;".join(self.__wrap_text(str(e), 57))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continuation line under-indented for visual indent

"local_path":local_path,

self.__path_preview_cache[cache_key] = {"context_path":context_path,
"local_path":local_path,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing whitespace after ':'

self.__path_preview_cache[cache_key] = {"context_path":context_path,
"local_path":local_path,

self.__path_preview_cache[cache_key] = {"context_path":context_path,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing whitespace after ':'

@@ -668,14 +680,14 @@ def on_show_in_fs_gizmo_callback(self):
if len(files) == 0:
nuke.message("There are no %srenders for this node yet!\n"
"When you render, the files will be written to "
"the following location:\n\n%s"
"the following location:\n\n%s"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continuation line under-indented for visual indent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant