Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better midi parser, handles running status. Also support for all notes off #355

Merged
merged 5 commits into from
Sep 6, 2024

Conversation

bwhitman
Copy link
Collaborator

@bwhitman bwhitman commented Sep 6, 2024

  • starting in on midi parser (and also side work on mpremote for it)
  • fixed midi parser, and allowing midi.py to do all notes off

@bwhitman bwhitman requested a review from dpwe September 6, 2024 18:45
@bwhitman
Copy link
Collaborator Author

bwhitman commented Sep 6, 2024

I still can’t test running status but I’ve run through it in my head and it should work. All notes off (tested via Ableton) does work, and we now parse every midi message in the midi 1.0 specification properly (midi.py only handles a few, but it shouldn’t break other stuff)

I tested USB midi on Tulip CC, still is fine

I tested IAC midi on Tulip Desktop mac, still is fine

@bwhitman
Copy link
Collaborator Author

bwhitman commented Sep 6, 2024

#344

@bwhitman bwhitman merged commit 2d525c5 into main Sep 6, 2024
1 check passed
@bwhitman bwhitman deleted the midi-parser branch September 6, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant