Allow patches to be added at runtime #112
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an offline imessage design session about this, but basically, this allows anyone using AMY to add patches at runtime by giving
u1024,AMY_PATCH_STRING
where 1024 is a patch number from 1024-1055. This message must be the only thing in the string sent over.amy.py
will parse it and send it right away, andamy.c
will treat the rest of the message as a patch, not further messages.So you can do:
We divine the number of oscs used for the patch at store_patch time. If you store a new patch over an old one, that old memory is freed and re-allocated. We rely on
malloc
for all of this.Also recall you can "record" patches in
amy.py
, so the whole loop is: