Custom oscillator #102
Merged
Custom oscillator #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very cool. We'll take a look asap!! |
|
Thanks for this @erkkah ! I had to make a few changes to keep it up to date with our more recent changes but everything looks good and i'll merge it in. |
|
Awesome, and thanks for this great library! 🎶 |
bwhitman
added a commit
that referenced
this pull request
Apr 23, 2024
we need to access both msynth and synth in some oscillators. and passing along the osc # is cleaner for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
I wanted to experiment with my own oscillator types without having to tweak the innards of amy, so I added support for a custom oscillator type.
This PR also makes it easier to pull in amy as a submodule and supplying a project-local "amy_config.h" by defining AMY_CONFIG_H. I also disabled the warning for building amy in "float" mode, since that is a valid use case.
And - I split the status/wave "OFF" constant into STATUS_OFF and WAVE_OFF.
If this is too much for a single PR, just let me know, I'm happy to split it up. Just wanted to share!