-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SHORA-2147 Add TF support for new symbol secret_mapping #134
Open
amalia101
wants to merge
4
commits into
shorelinesoftware:main
Choose a base branch
from
amalia101:SHORA-2147
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amalia101
changed the title
SHORA-2147 https://jirasw.nvidia.com/browse/SHORA-2147
SHORA-2147 Add TF support for new symbol secret_mapping
Dec 18, 2024
provider/provider_conf.go
Outdated
@@ -341,7 +352,8 @@ var ObjectConfigJsonStr = ` | |||
"principal": "An authorization group (e.g. Okta groups). Note: Admin privilege (in Shoreline) to create principal objects.", | |||
"resource": "A server or compute resource in the system (e.g. host, pod, container).\n\nSee the Shoreline [Resources Documentation](https://docs.shoreline.io/platform/resources) for more info.", | |||
"system_settings": "System-level settings. Note: there must only be one instance of this terraform resource named 'system_settings'.\n\nSee the Shoreline [Settings Documentation](https://docs.shoreline.io/platform/settings) for more info.", | |||
"report_template": "A resource report template. Note: Configure privilege (in Shoreline) to create report template objects." | |||
"report_template": "A resource report template. Note: Configure privilege (in Shoreline) to create report template objects.", | |||
"secret_mapping": "A mapping associated with a secret available in Shoreline." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add this mention somewhere: "and usable within the context of a runbook".
Lucian-Bosinceanu
approved these changes
Dec 19, 2024
sergiuiacob1
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jirasw.nvidia.com/browse/SHORA-2147