chore: access key and secret key can be empty if role is used #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why you want to leave them empty? They are required for Shopware to work |
No. See. It's also important when you want to use a role instead of the actual credentials when you deploy to EKS. |
|
We use irsa service roles for aws so it's fine if this is empty. But we are missing then the serviceAccount in each deployment and also in the jobs. |
|
And we need to remove the aws environment variables if they access and secret key is not set. |
|
If the service account is not generated in the operator itself it should be passed through the crd. And if the crd has no service account we should not attach it at all. |
TrayserCassa
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.