feat: add possibility to disable job deletion

shopware · Oct 25, 2024 · 422d740 · 422d740
1 parent 7714515
commit 422d740
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/api/v1/store.go b/api/v1/store.go
@@ -40,7 +40,8 @@ type StoreSpec struct {
 	ServiceAccountName      string        `json:"serviceAccountName,omitempty"`
 
 	// +kubebuilder:default=false
-	DisableChecks bool `json:"disableChecks,omitempty"`
+	DisableChecks      bool `json:"disableChecks,omitempty"`
+	DisableJobDeletion bool `json:"disableJobDeletion,omitempty"`
 
 	// +kubebuilder:default={adapter: "builtin"}
 	SessionCache SessionCacheSpec `json:"sessionCache"`

diff --git a/internal/controller/store_controller.go b/internal/controller/store_controller.go
@@ -194,7 +194,7 @@ func (r *StoreReconciler) doReconcile(
 	// EDIT: This makes more problems then it will help. So we process the way of terminating to
 	// the user to close all sidecars correctly.
 	// Check if sidecars are active
-	if len(store.Spec.Container.ExtraContainers) > 0 {
+	if len(store.Spec.Container.ExtraContainers) > 0 && !store.Spec.DisableJobDeletion {
 		log.Info("Delete setup/migration job if they are finished because sidecars are used")
 		if err := r.completeJobs(ctx, store); err != nil {
 			log.Error(err, "Can't cleanup setup and migration jobs")