Add sparse copy #5147
Closed
Add sparse copy #5147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What do you mean with "sparse_copy"? Is this meant to be "shallow_copy"? If so you should rename it, as sparse is usually associated in this library with sparse matrices (the opposite of dense matrix) |
|
Re-open when devs are back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5058
A free function which has default flags as mentioned in the issue. Pretty much same as make_clone, but it "motivates" sparse copying.
SGMatrix, and Features.h seems to be potential contenders for this sparse_copy OR make_clone(for entire deep copy), we can handle them both in this PR? @gf712
My thought process is to use make_clone for deep copy only and sparse_copy for if we want to copy only certain component(and therefore I've changed it in RelaxedTree).