Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SigmoidKernel constructors cleanup #5031

Merged

Conversation

gf712
Copy link
Member

@gf712 gf712 commented May 14, 2020

Example of how to refactor constructors #5030
For future reference: remember that the member initializer list is guaranteed to be executed before the body of the constructor.

@gf712 gf712 force-pushed the sigmoid_kernel_delegating_constructors branch from 01637ce to 4c7c94d Compare May 14, 2020 11:45
Copy link
Member

@karlnapf karlnapf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gf712 gf712 merged commit 7014676 into shogun-toolbox:develop May 14, 2020
@gf712 gf712 deleted the sigmoid_kernel_delegating_constructors branch May 14, 2020 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants