Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dashboard using Plotly Dash. #4

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

Hephaestus12
Copy link
Contributor

No description provided.

Copy link

@geektoni geektoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some commits of general nitpicking :) I am just wondering why there are so many classes copied directly from the previous code for the web application. Is it possible to reuse them or do you plan to delete the old ones instead?

@Hephaestus12
Copy link
Contributor Author

Commented code removed.
Now this saves calculated estimates as well :)

@Hephaestus12
Copy link
Contributor Author

All that's left now is to upload it to dockerhub.

@Hephaestus12
Copy link
Contributor Author

@geektoni
Copy link

I was able to pull the new docker image and it looks very nice :) I also tried to play with the various options in the control panel but they do not seem to work yet. Secondly, I've seen that there are also other graphs which are still empty though. Could you elaborate a list of things which are missing and you still need to implement to have all the new interface up and running?

@Hephaestus12
Copy link
Contributor Author

I was able to pull the new docker image and it looks very nice :) I also tried to play with the various options in the control panel but they do not seem to work yet. Secondly, I've seen that there are also other graphs which are still empty though. Could you elaborate a list of things which are missing and you still need to implement to have all the new interface up and running?

I don't understand? Everything works when I run it, Can you send me a screenshot of your screen?

@geektoni
Copy link

I was able to pull the new docker image and it looks very nice :) I also tried to play with the various options in the control panel but they do not seem to work yet. Secondly, I've seen that there are also other graphs which are still empty though. Could you elaborate a list of things which are missing and you still need to implement to have all the new interface up and running?

I don't understand? Everything works when I run it, Can you send me a screenshot of your screen?

I just checked again and the other graphs indeed work (not for all the possible combinations though). Would it be possible to set already some default values in the control panel such to have some data displayed form the beginning?

@Hephaestus12
Copy link
Contributor Author

Yes, all possible combinations don't work, primarily because of the years.
For example, in the dataset, I only have access to the pageviews from one country for the year 2008. As a result if you choose just 2008 and some other country, it shows zero cases. I'll try to reduce the ambiguity in this.

@geektoni
Copy link

Apart from some nitpicking now it seems to be right :) are these latest changes already on docker-hub?

@Hephaestus12
Copy link
Contributor Author

Apart from some nitpicking now it seems to be right :) are these latest changes already on docker-hub?

Thanks, and yes, it is published to docker-hub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants