Fix sl-select padding issue with multiple and placeholder options combined #2292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… medium or large size
…he select prefix when placeholder is present
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
claviska
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
#2279
#2291
Description
Updated styles so that some of the style adjustments (combobox padding and prefix margin) made to
sl-selectwithmultipleoptions do not get applied when the placeholder is shownI combined the solutions to these two issues since it looks like #2279 was caused by a fix for a previous issue similar to 2291 (see: #2194 ).