Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mariabackup-script #135

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

federico-razzoli
Copy link
Contributor

I hadn't the time to test this yet, but it seems fairly useful. License is GPL3 (after my request).

Copy link
Collaborator

@dveeden dveeden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the very early stages and might need a bit of improvements to make it easier to use and to make it a bit more resilient etc. Maybe adding it to this list could help with that.

@dveeden dveeden requested a review from shlomi-noach July 8, 2024 05:54
@shlomi-noach
Copy link
Owner

The script looks legit. I think we should understand how widely this is used first? Is it commonly known? I don't think this curated list should be a platform for publishing unknown tools, but rather more to assist in finding the known and tested tools.

@shlomi-noach
Copy link
Owner

For reference, this is from the contributing guidelines:

Must be reasonably recognized and adopted. Please do not add your newly created untested scripts.
The code must have been active in some production environment and must be in a reasonably GA quality.

I'd love to understand better the state of this script as per the above.

@dveeden dveeden self-requested a review July 8, 2024 07:21
@dveeden
Copy link
Collaborator

dveeden commented Jul 8, 2024

I don't think this matches that part of the guidelines.

@federico-razzoli
Copy link
Contributor Author

My personal guess: it was made for a specific environment / use case and not contributed by others yet.

I plan to use it for customers and contribute when improvements are needed. You might close the PR and reconsider it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants