Conditional notification #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shizunge
reviewed
Jun 7, 2024
| @@ -98,6 +98,8 @@ You can configure the most behaviors of *Gantry* via environment variables. | |||
| | GANTRY_CLEANUP_IMAGES_OPTIONS | | [Options](https://docs.docker.com/engine/reference/commandline/service_create/#options) added to the `docker service create` command to create a global job for images removal. You can use this to add a label to the service or the containers. | | |||
| | GANTRY_NOTIFICATION_APPRISE_URL | | Enable notifications on service update with [apprise](https://github.com/caronc/apprise-api). This must point to the notification endpoint (e.g. `http://apprise:8000/notify`) | | |||
| | GANTRY_NOTIFICATION_TITLE | | Add an additional message to the notification title. | | |||
| | GANTRY_NOTIFICATION_CONDITION | all | Specifies the conditions under which notifications are sent. | |||
There was a problem hiding this comment.
Can you list all valid values at beginning. like line 79.
| @@ -400,7 +400,17 @@ _report_services() { | |||
| local TITLE BODY | |||
| TITLE="[${STACK}] ${NUM_UPDATED} services updated ${NUM_FAILED} failed${ERROR_STRING}" | |||
| BODY=$(echo -e "${UPDATED_MSG}\n${FAILED_MSG}\n${ERROR_MSG}") | |||
| _send_notification "${TYPE}" "${TITLE}" "${BODY}" | |||
|
|
|||
| case "${GANTRY_NOTIFICATION_CONDITION:-all}" in | |||
There was a problem hiding this comment.
Assign global variable to a local one like line 276.
This avoids accidentally changing the global variable, or the global variable get different default values.
| case "${GANTRY_NOTIFICATION_CONDITION:-all}" in | ||
| changed-only) | ||
| if [ "${NUM_UPDATED}" -gt 0 ] || [ "${NUM_TOTAL_ERRORS}" -gt 0 ]; then | ||
| _send_notification "${TYPE}" "${TITLE}" "${BODY}" |
There was a problem hiding this comment.
Line 407 and 411 are same. They should be combined. like
if (some condition) {
_send_notification
}
|
Closes due to #54 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is an implementation for #38 (not yet tested)