Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: yaml config file #90

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Feat: yaml config file #90

wants to merge 1 commit into from

Conversation

sudo-Tiz
Copy link

@sudo-Tiz sudo-Tiz commented Jan 28, 2024

I am currently on smartphone and i can't test the code (linked to #88 )

I am currently on smartphone and i can't test the code
@sudo-Tiz
Copy link
Author

Code have to be modified to set the default value if not defined neither in the config-file neither in cli args

@sudo-Tiz sudo-Tiz mentioned this pull request Jan 28, 2024
@shizunge
Copy link
Owner

shizunge commented Jan 29, 2024

Thanks for the CL.

However we need more cleanup before checkin this: As now we have two ways to setup the config, and we may add env in the future, I would like to move the corresponding code to their own package.

In the mean time, you can help

  • Updating the README. If you want, you can create a new file in a new docs folder.
  • Adding examples how to use the config file.

We can have docs as specification, and examples as test input before implementing things.

@shizunge
Copy link
Owner

shizunge commented Oct 7, 2024

Current roadmap:

  1. Create integration tests, including tests of the CLI arguments.
  2. Update github actions
  3. Read config file from yaml and/or ENV. traefik is doing it, we may borrow some codes there. (Note: traefik is under MIT license)
  4. Build a new data processing pipeline, updating Prometheus metrics will be one stage of the pipeline.
  5. enable-abuseipdb reporting, which will be a parallel stage of updating Prometheus metrics.

I will review this CL when we finish previous steps.

This CL is at step 3 above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants