Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend: Improved Navbar by dynamic links #177

Closed
wants to merge 1 commit into from

Conversation

PrathamX595
Copy link
Contributor

@PrathamX595 PrathamX595 commented Jun 30, 2024

Frontend: Improved Navbar by dynamic links

now the navbar uses a list of links to render different buttons as required by the links

Fixes: #122

Description

earlier the Navbar links were hard coded now the links are kept in an array from which the buttons are rendered as per need.

Checklist

  • I have tested these changes locally.
  • I have reviewed the code and ensured it follows the project's coding guidelines.
  • [] I have updated the documentation, if necessary.
  • [] I have assigned reviewers to this pull request.

Copy link

vercel bot commented Jun 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
multiplayer-uno ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 30, 2024 7:18pm

@kuv2707
Copy link
Collaborator

kuv2707 commented Jun 30, 2024

This should be merged after #176, which can cause some conflicts. Just a heads up

@kuv2707
Copy link
Collaborator

kuv2707 commented Jun 30, 2024

@PrathamX595 Let me know when you resolve the conflicts

@PrathamX595
Copy link
Contributor Author

@PrathamX595 Let me know when you resolve the conflicts

resolved all conflicts

>>
>>     now the navbar uses a list of links to render different buttons as required by the links
>>
>>     Fixes: shivansh-bhatnagar18#122
@kuv2707
Copy link
Collaborator

kuv2707 commented Jul 1, 2024

Made some minor changes and pushed the commit, thanks @PrathamX595

This is the last PR of the event!🎉

@kuv2707 kuv2707 closed this Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the navbar
2 participants