Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend: Display Player names along with cards #171

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Frontend: Display Player names along with cards #171

merged 1 commit into from
Jun 28, 2024

Conversation

asmit27rai
Copy link
Contributor

Fixes #158

Description

  1. The Player component was refactored to separate JSX for rendering player cards.

  2. Highlighting functionality was added to indicate the current player's turn.

  3. Player names were styled to appear in a white box with black text.

  4. Brightness adjustment was applied to highlight the active player.

Checklist

  • I have tested these changes locally.
  • I have reviewed the code and ensured it follows the project's coding guidelines.
  • I have updated the documentation, if necessary.
  • I have assigned reviewers to this pull request.

Screenshots (if applicable)

Screenshot 2024-06-27 184300

@vercel Vercel
Copy link

vercel bot commented Jun 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
multiplayer-uno ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2024 2:37pm

@kuv2707
Copy link
Collaborator

kuv2707 commented Jun 28, 2024

@asmit27rai Please fix the merge conflicts

@kuv2707 @asmit27rai
Frontend: Display Player names along with cards
ad1c831 
1. The Player component was refactored to separate JSX for rendering player cards.

2. Highlighting functionality was added to indicate the current player's turn.

3. Player names were styled to appear in a white box with black text.

4. Brightness adjustment was applied to highlight the active player.

Fixes shivansh-bhatnagar18#158
@asmit27rai
Copy link
Contributor Author

@asmit27rai Please fix the merge conflicts

@kuv2707 Done.

@kuv2707 kuv2707 merged commit 0a50b2e into shivansh-bhatnagar18:master Jun 28, 2024
8 checks passed
@kuv2707
Copy link
Collaborator

kuv2707 commented Jun 28, 2024

Merged, thanks @asmit27rai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display player names along with cards
2 participants
@asmit27rai @kuv2707