GamePage: Added the Game properties button and leave game button in modal #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kuv2707
reviewed
Jun 25, 2024
kuv2707
reviewed
Jun 25, 2024
sksmagr23
force-pushed
the
fix/issue-#161
branch
from
4f341c6 to
3d75c7f
Compare
|
@kuv2707 implemented the reviewed change |
kuv2707
reviewed
Jun 25, 2024
sksmagr23
force-pushed
the
fix/issue-#161
branch
from
3d75c7f to
b8c8063
Compare
|
Done the change , you can review it |
|
Once you resolve the minor merge conflict, it can be merged |
The game properties button is added at bottom left of the gamepage, on clicking. we can anytime open and display the GamePropertiesModal. fixes shivansh-bhatnagar18#161
Added a Leave game button in GamePropertiesModal which triggers the LEAVE_GAME event and navigates to homepage. fixes shivansh-bhatnagar18#161
sksmagr23
force-pushed
the
fix/issue-#161
branch
from
b8c8063 to
763e2fd
Compare
|
Resolved the merge conflict, can be merged now |
|
Merged, thanks @sksmagr23 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The game properties button is added at bottom left of the gamepage, on clicking. we can anytime open and display the GamePropertiesModal within the game.
Also added a Leave game button in GamePropertiesModal which triggers the LEAVE_GAME event using channel.triggerEvent and navigates to homepage.
Both changes done in seperate commits.
fixes #161
How to Test
Related Issues
Checklist
Screenshots
Screencast.from.2024-06-25.16-48-38.webm