-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Extend Dockerfile based build strategies with target build stage #1737
base: main
Are you sure you want to change the base?
WIP Extend Dockerfile based build strategies with target build stage #1737
Conversation
Signed-off-by: Sascha Schwarze <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
very interesting, can you reference https://docs.docker.com/build/building/multi-stage/#stop-at-a-specific-build-stage in the above PR description. What are the use cases on this for SHP users? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
The Dockerfile that I had stumbled over this is https://github.com/ONLYOFFICE/Docker-Docs/blob/v8.2.1-1/Dockerfile. It is a single Dockerfile that you must run for targets like proxy, converter or docservice to produce the different images you need for onlyoffice. |
Changes
I recently stumbled over a single Dockerfile that combined multiple output images and one had to run
docker build --target STAGE
to select which one should actually be built. And that was not possible with our sample build strategies because we had no parameter for the target stage. Adding this. Related Dockerfile feature: https://docs.docker.com/build/building/multi-stage/#stop-at-a-specific-build-stagee2e will be added when shipwright-io/sample-go#16 is merged
Submitter Checklist
Release Notes