-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rework eslint config #188
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0t4u
force-pushed
the
feat/new-eslint-config
branch
from
August 10, 2024 08:57
0d056bf
to
84b55b1
Compare
Deivu
requested changes
Aug 11, 2024
Deivu
requested changes
Aug 11, 2024
Why tabs? We do 4 spaces for all of our other repos?
…On Sun, 11 Aug 2024 at 10:21, Saya ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In eslint.config.mjs
<#188 (comment)>
:
> + // await augu.typescript(),
+ stylistic.configs['disable-legacy'],
+ {
+ languageOptions: {
+ parserOptions: {
+ projectService: true,
+ tsconfigRootDir: import.meta.dirname
+ }
+ },
+ plugins: {
+ ***@***.***': stylistic
+ },
+ rules: {
+ ***@***.***/semi': [ 'error' ],
+ ***@***.***/member-delimiter-style': [ 'error' ],
+ ***@***.***/indent': [ 'error', 4, { 'SwitchCase': 1 }],
Use tabs for indents
------------------------------
On eslint.config.mjs
<#188 (comment)>
:
We should consider moving our eslint config to a dedicated repo so we can
keep the coding style consistent through out our ts and js projects
Can be left for future, but something we need to do
—
Reply to this email directly, view it on GitHub
<#188 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOYR3RRM5BAZXAZNOUNWYHDZQ3DDFAVCNFSM6AAAAABMJUN2ECVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMZRG4ZDONJSGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Tabs are more consistent and faster to use, Kashima and Suzutsuki is already using it. Other repos don't yet as I haven't touched those yet |
Deivu
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the old eslintrc file to the new flat config format, rework eslint config, and lint all files.