feat: update Player move method to accept MoveOptions #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0t4u
requested changes
Aug 1, 2024
0t4u
requested changes
Aug 1, 2024
|
@flav-code pls see changes requested, leave a comment on each change if you disagree |
Co-authored-by: 0t4u <[email protected]>
Co-authored-by: 0t4u <[email protected]>
Co-authored-by: 0t4u <[email protected]>
Co-authored-by: 0t4u <[email protected]>
Co-authored-by: 0t4u <[email protected]>
|
|
|
My bad, I'll take a look at overloads |
0t4u
reviewed
Aug 10, 2024
|
Can you remove the overload first please, so the build doesn't fail, or else I can't merge |
0t4u
approved these changes
Aug 12, 2024
|
Could you resolve the conflicts pls? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the "force" property is useful to move a player if a node disconnect