Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility to Opsview NRPE large output patch #3

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

xorpaul
Copy link
Contributor

@xorpaul xorpaul commented Dec 19, 2013

This is just pseudo code that should loop/receive NRPE response packets until it receives a normal NRPE response packet.

I patched my NRPE agents to support larger output than 1 kB:
http://www.opsview.com/whats-new/blog/enhancing-nrpe-large-output

The normal check_nrpe plugin shows the large output correctly, but because Shinken uses the nrpe_poller module it stops after receiving the first 1024 byte :/

I could not bring the nrpe_poller to loop/receive more than 1kB, could you have a look and give me a hint, where I need to loop over the NRPE client responses?

@Seb-Solon
Copy link
Contributor

Hi there!

Sorry for the delay! This seems legit, my only comment on that is to replace .info with .debug message :)

@gst
Copy link
Contributor

gst commented Apr 20, 2015

@xorpaul

are you still around for / with this patchset ?

there will certainly need some rebase/adaptation vs the last updates done in master branch but nothing hard.

@xorpaul
Copy link
Contributor Author

xorpaul commented May 20, 2015

Yeah, I'm still around, but I still could not bring the nrpe_poller to loop/receive more than 1kB, could you have a look and give me a hint, where I need to loop over the NRPE client responses?

@gst
Copy link
Contributor

gst commented May 20, 2015

I'm gonna give it a try on my side, based on what you try to do..

@gst
Copy link
Contributor

gst commented May 20, 2015

Think I've it done. Gonna open another PR with it.. you'll have to give it try..

but : the link you gave (http://www.opsview.com/whats-new/blog/enhancing-nrpe-large-output) doesn't lead anymore to the blog content.. I could found it in the web archive :
https://web.archive.org/web/20100722073353/http://labs.opsview.com/2008/08/enhancing-nrpe-for-large-output

some other references :
http://tracker.nagios.org/view.php?id=564 (most recent)
http://support.nagios.com/forum/viewtopic.php?f=34&t=25221
http://sourceforge.net/p/nagios/mailman/message/29052473/

@gst
Copy link
Contributor

gst commented May 20, 2015

there : #16

@gst
Copy link
Contributor

gst commented May 21, 2015

@xorpaul ping ;)

@xorpaul
Copy link
Contributor Author

xorpaul commented May 21, 2015

Yeah I saw it :)
Great work! Unfortunately I can't test it until tomorrow.
On May 21, 2015 4:16 PM, "Grégory Starck" [email protected] wrote:

@xorpaul https://github.com/xorpaul ping ;)


Reply to this email directly or view it on GitHub
#3 (comment)
.

@gst
Copy link
Contributor

gst commented May 21, 2015

ok that's fine for me ;)
waiting you back ++

@xorpaul
Copy link
Contributor Author

xorpaul commented May 27, 2015

Need more time to do this as I'm still running Shinken 1.4 and need to setup an up-to-date Shinken first :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants