The PR to compare upstream & this fork

Cargo.toml

@@ -10,23 +10,23 @@ keywords = ["forensics", "macOS", "unifiedlog"]
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
 [dependencies]
-nom = "7.1.3"
-serde_json = "1.0.133"
-serde = { version = "1.0.215", features = ["derive"] }
-log = "0.4.22"
+nom = { workspace = true }
+serde_json = { workspace = true }
+serde = { workspace = true }
+log = { workspace = true }
 lz4_flex = "0.11.3"
 byteorder = "1.5.0"
-plist = "1.7.0"
-regex = "1.11.1"
-base64 = "0.22.1"
-chrono = "0.4.38"
+plist = { workspace = true }
+regex = { workspace = true }
+base64 = { workspace = true }
+chrono = { workspace = true }
 
 [dev-dependencies]
 simplelog = "0.12.2"
-csv = "1.3.1"
-chrono = "0.4.38"
-criterion = "0.5.1"
-anyhow = "1.0.94"
+csv = { workspace = true }
+chrono = { workspace = true }
+criterion = { workspace = true }
+anyhow = { workspace = true }
 
 [[bench]]
 name = "high_sierra_benchmark"

benches/big_sur_benchmark.rs

@@ -4,7 +4,7 @@
 // Unless required by applicable law or agreed to in writing, software distributed under the License
 // is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and limitations under the License.
-
+#![allow(clippy::all, clippy::pedantic, clippy::restriction, clippy::nursery)]
 use std::path::PathBuf;
 
 use criterion::{criterion_group, criterion_main, Criterion};

benches/high_sierra_benchmark.rs

@@ -4,7 +4,7 @@
 // Unless required by applicable law or agreed to in writing, software distributed under the License
 // is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and limitations under the License.
-
+#![allow(clippy::all, clippy::pedantic, clippy::restriction, clippy::nursery)]
 use std::path::PathBuf;
 
 use criterion::{criterion_group, criterion_main, Criterion};

benches/monterey_benchmark.rs

@@ -4,7 +4,7 @@
 // Unless required by applicable law or agreed to in writing, software distributed under the License
 // is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and limitations under the License.
-
+#![allow(clippy::all, clippy::pedantic, clippy::restriction, clippy::nursery)]
 use std::path::PathBuf;
 
 use criterion::{criterion_group, criterion_main, Criterion};

examples/unifiedlog_parser/src/main.rs

@@ -5,6 +5,7 @@
 // is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and limitations under the License.
 
+#![allow(clippy::all, clippy::pedantic, clippy::restriction, clippy::nursery)]
 use chrono::{SecondsFormat, TimeZone, Utc};
 use log::LevelFilter;
 use macos_unifiedlogs::dsc::SharedCacheStrings;

src/decoders/decoder.rs

@@ -38,6 +38,10 @@ pub(crate) fn check_objects(
     let mut index = item_index;
     const PRECISION_ITEM: u8 = 0x12;
 
+    if index >= message_values.len() {
+        return format!("Index out of bounds for FirehoseItemInfo Vec. Got adjusted index {}, Vec size is {}. This should not have happened", index, message_values.len());
+    }
+
     // Increment index get the actual firehose item data
     if item_type == PRECISION_ITEM {
         index += 1;

src/lib.rs

@@ -31,13 +31,13 @@
     clippy::checked_conversions,
     clippy::unnecessary_cast
 )]
-
+#![allow(clippy::all, clippy::pedantic, clippy::restriction, clippy::nursery)]
 mod catalog;
-mod chunks;
+pub mod chunks;
 mod chunkset;
 mod decoders;
 pub mod dsc;
-mod error;
+pub mod error;
 mod header;
 pub mod iterator;
 mod message;

src/timesync.rs

@@ -76,8 +76,8 @@ impl TimesyncBoot {
         let expected_boot_signature = 0xbbb0;
         if expected_boot_signature != timesync_signature {
             error!(
-                "[macos-unifiedlogs] Incorrect Timesync boot header signature. Expected {}. Got: {}",
-                expected_boot_signature, timesync_signature
+              "[macos-unifiedlogs] Incorrect Timesync boot header signature. Expected {}. Got: {}",
+              expected_boot_signature, timesync_signature
             );
             return Err(nom::Err::Incomplete(Needed::Unknown));
         }
@@ -130,8 +130,8 @@ impl TimesyncBoot {
         let expected_record_signature = 0x207354;
         if expected_record_signature != timesync_signature {
             error!(
-                "[macos-unifiedlogs] Incorrect Timesync record header signature. Expected {}. Got: {}",
-                expected_record_signature, timesync_signature
+              "[macos-unifiedlogs] Incorrect Timesync record header signature. Expected {}. Got: {}",
+              expected_record_signature, timesync_signature
             );
             return Err(nom::Err::Incomplete(Needed::Unknown));
         }