Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent tab borders from colliding with containing widget if show_border = false (Fixes #228) #232

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Prevent tab borders from colliding with containing widget if show_border = false (Fixes #228) #232

wants to merge 2 commits into from

Commits on Sep 12, 2018

  1. Prevent tab borders from colliding with containing widget if show_bor… 

    …der = false (Fixes shimmerproject#228)

The core idea of show_border = false is to get rid of the border around
the widget and set the margins to zero to visually embed the widget
directly inside the containing widget, without introducing additional
borders.

To facilitate such design choices by applications, Greybird's tabs need
to be slightly moved to the right to prevent them from colliding with
the containing widget's borders.

A screenshot of how this looks in Greybird and other themes is supplied
in shimmerproject#228.
    @soc
    soc committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    479582f View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2018

  1. Set GtkNotebook's left/right/bottom borders to 0 if show_border=false

    @soc
    soc committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    7c7f541 View commit details
    Browse the repository at this point in the history