Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump oniguruma-to-es for grammar support and perf #842

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

slevithan
Copy link
Contributor

@slevithan slevithan commented Nov 22, 2024

Updates oniguruma-to-es to v0.6.0, and makes corresponding changes.

  • Option accuracy: 'loose' replaced by rules.allowUnhandledGAnchors.
    • Now implicitly using accuracy: 'default'.
  • Option tmGrammar replaced by rules.allowOrphanBackrefs.
  • Applied new option rules.asciiWordBoundaries for performance, since Unicode-based word boundaries are rarely needed, and the complex Unicode form for them is meaningfully slower.
    • This change doesn't alter results in the JS engine report.
  • An edge-case fix in the new version results in the number of supported grammars increasing by +1.

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for shiki-next ready!

Name Link
🔨 Latest commit 5d2df10
🔍 Latest deploy log https://app.netlify.com/sites/shiki-next/deploys/6740b646de8311000846fe3a
😎 Deploy Preview https://deploy-preview-842--shiki-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for shiki-matsu ready!

Name Link
🔨 Latest commit 5d2df10
🔍 Latest deploy log https://app.netlify.com/sites/shiki-matsu/deploys/6740b6462adff20008baa6d7
😎 Deploy Preview https://deploy-preview-842--shiki-matsu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@antfu
Copy link
Member

antfu commented Nov 23, 2024

Impressive! Thanks a lot!

@antfu antfu merged commit fc87512 into shikijs:main Nov 23, 2024
12 checks passed
@slevithan slevithan deleted the jsengine060 branch November 23, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants