Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(transformers): clarify that shiki does not parse meta #834

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

olets
Copy link
Contributor

@olets olets commented Nov 13, 2024

Description

Currently the docs imply that Shiki provides a parsed meta object. This change removes that implication. This change also provides an example of dashcased meta attribute keys and quoted meta attribute values.

Linked Issues

Additional context

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for shiki-matsu ready!

Name Link
🔨 Latest commit 6aabad1
🔍 Latest deploy log https://app.netlify.com/sites/shiki-matsu/deploys/6734efbc20f995000876a6f2
😎 Deploy Preview https://deploy-preview-834--shiki-matsu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for shiki-next ready!

Name Link
🔨 Latest commit 6aabad1
🔍 Latest deploy log https://app.netlify.com/sites/shiki-next/deploys/6734efbcf6dadc000850d62b
😎 Deploy Preview https://deploy-preview-834--shiki-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cworld1
Copy link

cworld1 commented Nov 13, 2024

If you want to help the reader more, I think it is very appropriate to provide a link to the issue #792 here, at least to let the reader know that there is a solution that may be helpful.

@antfu antfu merged commit 5d08484 into shikijs:main Nov 14, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants