Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rail undo/redo #79

Merged
merged 6 commits into from
Nov 28, 2023
Merged

Fix rail undo/redo #79

merged 6 commits into from
Nov 28, 2023

Conversation

ethanglide
Copy link
Contributor

  • Fixed an issue where undoing a rail move would set the point's position to world origin
  • Fixed an issue where redoing a rail move would keep the point in the same position
  • Added a QoL functionality where holding ctrl will cause rail points to snap to only valid locations

Admittedly the rail snapping functionality, while useful, is half-baked and I want to add more to it. But its serviceable for now and the main point of the PR is for the rail undo/redo.

If you hold down ctrl, it will only let you place the rail in a position that has valid angles with its neighbouring points
Still need to fix the new redo issue!
Believe it or not, all of this code that was deleted is not used.

There is still an issue of not being able to redo. I think that this whole thing will likely need to be redone to be working completely.
@jupahe64 jupahe64 merged commit 5bfe25e into shibbo:main Nov 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants