Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sampling with a unicode prime work correctly #106

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

IvanVergiliev
Copy link

Running sample.py with a unicode prime fails with something in the
spirit of

sample.py: error: argument --prime: invalid unicode value: [...]

Using the approach suggested in
https://stackoverflow.com/a/22947334/596167 appears to fix things.

Running `sample.py` with a unicode prime fails with something in the
spirit of

```
sample.py: error: argument --prime: invalid unicode value: [...]
```

Using the approach suggested in
https://stackoverflow.com/a/22947334/596167 appears to fix things.
@hugovk
Copy link
Contributor

hugovk commented Jun 19, 2017

@IvanVergiliev The build failed because:

./sample.py:10: 'six.text_type' imported but unused

Please remove the import. Thank you.

@IvanVergiliev
Copy link
Author

Done. Also, apparently the old default value (u' ') was incompatible with the new type so I changed that as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants