Skip to content

Commit

Permalink
Add ImpIds in RequestData for associated Impressions (prebid#3364)
Browse files Browse the repository at this point in the history
  • Loading branch information
pm-saurabh-narkhede authored Apr 10, 2024
1 parent 9cd1b3d commit 2cc2c90
Show file tree
Hide file tree
Showing 2,207 changed files with 4,469 additions and 2,102 deletions.
1 change: 1 addition & 0 deletions adapters/33across/33across.go
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ func (a *TtxAdapter) makeRequest(request openrtb2.BidRequest, impList []openrtb2
Uri: a.endpoint,
Body: reqJSON,
Headers: headers,
ImpIDs: openrtb_ext.GetImpIDs(request.Imp),
}, nil
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,8 @@
}
],
"site": {}
}
},
"impIDs":["test-imp-id"]
},
"mockResponse": {
"status": 200,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@
}
],
"site": {}
}
},
"impIDs":["test-imp-id"]
},
"mockResponse": {
"status": 200,
Expand Down
3 changes: 2 additions & 1 deletion adapters/33across/33acrosstest/exemplary/multi-format.json
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@
}
],
"site": {}
}
},
"impIDs":["test-imp-id"]
},
"mockResponse": {
"status": 200,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,8 @@
}
],
"site": {}
}
},
"impIDs":["test-imp-id1","test-imp-id2"]
},
"mockResponse": {
"status": 200,
Expand Down Expand Up @@ -172,7 +173,8 @@
}
],
"site": {}
}
},
"impIDs":["test-imp-id3"]
},
"mockResponse": {
"status": 200,
Expand Down Expand Up @@ -233,7 +235,8 @@
}
],
"site": {}
}
},
"impIDs":["test-imp-id4"]
},
"mockResponse": {
"status": 200,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@
}
],
"site": {}
}
},
"impIDs":["test-imp-id"]
},
"mockResponse": {
"status": 204
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@
}
],
"site": {}
}
},
"impIDs":["test-imp-id"]
},
"mockResponse": {
"status": 200,
Expand Down
3 changes: 2 additions & 1 deletion adapters/33across/33acrosstest/exemplary/site-banner.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@
}
],
"site": {}
}
},
"impIDs":["test-imp-id"]
},
"mockResponse": {
"status": 200,
Expand Down
3 changes: 2 additions & 1 deletion adapters/33across/33acrosstest/exemplary/site-video.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,8 @@
}
],
"site": {}
}
},
"impIDs":["test-imp-id"]
},
"mockResponse": {
"status": 200,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@
}
],
"site": {}
}
},
"impIDs":["test-imp-id1"]
},
"mockResponse": {
"status": 200,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@
}
],
"site": {}
}
},
"impIDs":["test-imp-id"]
},
"mockResponse": {
"status": 400,
Expand Down
1 change: 1 addition & 0 deletions adapters/aax/aax.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ func (a *adapter) MakeRequests(request *openrtb2.BidRequest, reqInfo *adapters.E
Uri: a.endpoint,
Body: reqJson,
Headers: headers,
ImpIDs: openrtb_ext.GetImpIDs(request.Imp),
}}, errs
}

Expand Down
3 changes: 2 additions & 1 deletion adapters/aax/aaxtest/exemplary/multi-format.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@
}
}
]
}
},
"impIDs":["1"]
},
"mockResponse": {
"status": 204,
Expand Down
3 changes: 2 additions & 1 deletion adapters/aax/aaxtest/exemplary/multi-imps.json
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,8 @@
}
}
]
}
},
"impIDs":["1","2"]
},
"mockResponse": {
"status": 200,
Expand Down
3 changes: 2 additions & 1 deletion adapters/aax/aaxtest/exemplary/no-bid.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@
}
}
]
}
},
"impIDs":["1"]
},
"mockResponse": {
"status": 204,
Expand Down
3 changes: 2 additions & 1 deletion adapters/aax/aaxtest/exemplary/optional-params.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@
}
}
]
}
},
"impIDs":["1"]
},
"mockResponse": {
"status": 204,
Expand Down
3 changes: 2 additions & 1 deletion adapters/aax/aaxtest/exemplary/simple-banner.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@
}
}
]
}
},
"impIDs":["1"]
},
"mockResponse": {
"status": 200,
Expand Down
3 changes: 2 additions & 1 deletion adapters/aax/aaxtest/exemplary/simple-video.json
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@
}
}
]
}
},
"impIDs":["1"]
},
"mockResponse": {
"status": 200,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,8 @@
"buyeruid": "0000-000-000-0000"
},
"tmax": 1000
}
},
"impIDs":["some-impression-id"]
},
"mockResponse": {
"status": 400
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,8 @@
"gdpr": 0
}
}
}
},
"impIDs":["test-imp-id"]
},
"mockResponse": {
"status": 200,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,8 @@
"gdpr": 0
}
}
}
},
"impIDs":["test-imp-id"]
},
"mockResponse": {
"status": 200,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,8 @@
"gdpr": 0
}
}
}
},
"impIDs":["test-imp-id"]
},
"mockResponse": {
"status": 200,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@
"id": "imp-id"
}
]
}
},
"impIDs":["imp-id"]
},
"mockResponse": {
"status": 204,
Expand Down
1 change: 1 addition & 0 deletions adapters/aceex/aceex.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ func (a *adapter) MakeRequests(
Body: reqJSON,
Uri: url,
Headers: getHeaders(openRTBRequest),
ImpIDs: openrtb_ext.GetImpIDs(openRTBRequest.Imp),
}}, nil
}

Expand Down
3 changes: 2 additions & 1 deletion adapters/aceex/aceextest/exemplary/banner-app.json
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,8 @@
"buyeruid": "awesome-user"
},
"tmax": 1000
}
},
"impIDs":["some-impression-id"]
},
"mockResponse": {
"status": 200,
Expand Down
3 changes: 2 additions & 1 deletion adapters/aceex/aceextest/exemplary/banner-web.json
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,8 @@
"buyeruid": "awesome-user"
},
"tmax": 1000
}
},
"impIDs":["some-impression-id"]
},
"mockResponse": {
"status": 200,
Expand Down
3 changes: 2 additions & 1 deletion adapters/aceex/aceextest/exemplary/native-app.json
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,8 @@
"buyeruid": "awesome-user"
},
"tmax": 1000
}
},
"impIDs":["some-impression-id"]
},
"mockResponse": {
"status": 200,
Expand Down
3 changes: 2 additions & 1 deletion adapters/aceex/aceextest/exemplary/native-web.json
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,8 @@
"buyeruid": "awesome-user"
},
"tmax": 1000
}
},
"impIDs":["some-impression-id"]
},
"mockResponse": {
"status": 200,
Expand Down
3 changes: 2 additions & 1 deletion adapters/aceex/aceextest/exemplary/video-app.json
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,8 @@
"buyeruid": "awesome-user"
},
"tmax": 1000
}
},
"impIDs":["some-impression-id"]
},
"mockResponse": {
"status": 200,
Expand Down
3 changes: 2 additions & 1 deletion adapters/aceex/aceextest/exemplary/video-web.json
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,8 @@
"buyeruid": "awesome-user"
},
"tmax": 1000
}
},
"impIDs":["some-impression-id"]
},
"mockResponse": {
"status": 200,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,8 @@
"buyeruid": "awesome-user"
},
"tmax": 1000
}
},
"impIDs":["some-impression-id"]
},
"mockResponse": {
"status": 200,
Expand Down
3 changes: 2 additions & 1 deletion adapters/aceex/aceextest/supplemental/invalid-response.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@
"buyeruid": "awesome-user"
},
"tmax": 1000
}
},
"impIDs":["some-impression-id"]
},
"mockResponse": {
"status": 200,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,8 @@
"buyeruid": "awesome-user"
},
"tmax": 1000
}
},
"impIDs":["some-impression-id"]
},
"mockResponse": {
"status": 400
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@
"buyeruid": "awesome-user"
},
"tmax": 1000
}
},
"impIDs":["some-impression-id"]
},
"mockResponse": {
"status": 204
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@
"buyeruid": "awesome-user"
},
"tmax": 1000
}
},
"impIDs":["some-impression-id"]
},
"mockResponse": {
"status": 306
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@
"buyeruid": "awesome-user"
},
"tmax": 1000
}
},
"impIDs":["some-impression-id"]
},
"mockResponse": {
"status": 503
Expand Down
1 change: 1 addition & 0 deletions adapters/acuityads/acuityads.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ func (a *AcuityAdsAdapter) MakeRequests(
Body: reqJSON,
Uri: url,
Headers: getHeaders(openRTBRequest),
ImpIDs: openrtb_ext.GetImpIDs(openRTBRequest.Imp),
}}, nil
}

Expand Down
3 changes: 2 additions & 1 deletion adapters/acuityads/acuityadstest/exemplary/banner-app.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@
"buyeruid": "awesome-user"
},
"tmax": 1000
}
},
"impIDs":["some-impression-id"]
},
"mockResponse": {
"status": 200,
Expand Down
Loading

0 comments on commit 2cc2c90

Please sign in to comment.