🐛 Fix inflight/pending callbacks execute in wrong order

[benjismith]

I encountered a situation in ShareDB where my callbacks are often executed in the wrong order.

I tracked this down to incorrect behavior in the doc.fetch() method, which pushes the inflightCallback onto the back of the callbacks array. If there are already any pendingCallbacks in the array, then the inflightCallback will be executed AFTER all the pendingCallbacks.

This is obviously not the desired behavior. The inflightCallback should always be executed FIRST, before any of the pendingCallbacks.

I fixed the code and wrote a test demonstrating the fix. If you remove my bugfix and run the test, you'll see that it reliably fails.

[alecgibson]

Thanks for the submission! I've looked into the build failure; looks like it's an upstream Node.js issue 😬

Have run the tests (and linting) locally and it works fine for me.

[alecgibson]

Looks sensible, but will have a quick sense-check with @ericyhwang tomorrow

[benjismith]

Any news?

[alecgibson]

@benjismith sorry our PR meeting last week was cancelled. @ericyhwang you around to discuss today? Or happy to take a look async?

[coveralls]

coverage: 97.445%. remained the same
when pulling 7aa4f32 on benjismith:master
into 161d8b5 on share:master.

[ericyhwang]

Sorry for the delay, I was out last week. Makes sense to me.

[alecgibson]

Released in https://github.com/share/sharedb/releases/tag/v5.0.3

[benjismith]

Awesome, thank you!