fix: Panic if ProcessActiveStandBy returns error (milvus-io#33369)

milvus-io#33368 Signed-off-by: wayblink <[email protected]>
shaoting-huang · Jun 19, 2024 · 5fac2fa · 5fac2fa
1 parent 0294595
commit 5fac2fa
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/internal/datacoord/server.go b/internal/datacoord/server.go
@@ -276,13 +276,13 @@ func (s *Server) Register() error {
 			err := s.session.ProcessActiveStandBy(s.activateFunc)
 			if err != nil {
 				log.Error("failed to activate standby datacoord server", zap.Error(err))
-				return
+				panic(err)
 			}
 
 			err = s.icSession.ForceActiveStandby(nil)
 			if err != nil {
 				log.Error("failed to force activate standby indexcoord server", zap.Error(err))
-				return
+				panic(err)
 			}
 			afterRegister()
 		}()

diff --git a/internal/querycoordv2/server.go b/internal/querycoordv2/server.go
@@ -160,7 +160,7 @@ func (s *Server) Register() error {
 		go func() {
 			if err := s.session.ProcessActiveStandBy(s.activateFunc); err != nil {
 				log.Error("failed to activate standby server", zap.Error(err))
-				return
+				panic(err)
 			}
 			afterRegister()
 		}()

diff --git a/internal/rootcoord/root_coord.go b/internal/rootcoord/root_coord.go
@@ -280,7 +280,7 @@ func (c *Core) Register() error {
 		go func() {
 			if err := c.session.ProcessActiveStandBy(c.activateFunc); err != nil {
 				log.Warn("failed to activate standby rootcoord server", zap.Error(err))
-				return
+				panic(err)
 			}
 			afterRegister()
 		}()