CSharp_郭雯齐_无21 #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shangfengh
reviewed
Jul 30, 2023
| @@ -60,6 +60,62 @@ public class Progress : IProgress | |||
| // 一个进度条 | |||
| // 只允许修改Progress类中的代码 | |||
| // 要求实现IProgress中的要求 | |||
| public int Num { get; set;} | |||
| public int RequiredProgress { get; set; } | |||
| public int FinishedProgress { get; set; } | |||
There was a problem hiding this comment.
本意是希望能在set访问器里限制 FinishedProgress的范围的，特别是多人研发时能确保安全。
但是事实上即便设置了属性，类内依旧可以访问字段，属性更像对类外操作的要求。
所以不开放set访问器（要保证赋值总是合法的，不能让外界无条件修改），只在方法内进行范围限制也合理
这里为了不让外界无条件修改，应该考虑private set
| } | ||
| public bool Start(int requiredProgress) | ||
| { | ||
| if (requiredProgress < 0) |
There was a problem hiding this comment.
描述里“如果之前进度条已经加载完成，则将进度清零开始下一次加载，返回true，但如果requiredProgress<0，应当报错”，if (requiredProgress < 0)应该在 if (FinishedProgress >= RequiredProgress)
| { | ||
| FinishedProgress = 0; | ||
| if(RequiredProgress!=0) | ||
| Num++; |
There was a problem hiding this comment.
Progress的序号，表明是第几个实例化的Progress，不是指第几次Start
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.