Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

csharp_尤忆晨_无23 #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

csharp_尤忆晨_无23 #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 67 additions & 5 deletions hw1/hw1/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,73 @@ public interface IProgress
public (int FinishedProgress, int RequiredProgress) GetProgress();
}

public class Progress : IProgress
public class Progress : IProgress
{
// 一个进度条
// 只允许修改Progress类中的代码
// 要求实现IProgress中的要求
private int num;
private int requiredProgress;
private int finishedProgress;

public Progress()
{
num = 0;
requiredProgress = 0;
finishedProgress = 0;
}

public int Num => num;
public int RequiredProgress => requiredProgress;
public int FinishedProgress => finishedProgress;
Copy link
Owner

@shangfengh shangfengh Jul 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

本意是希望能在set访问器里限制 FinishedProgress的范围的，特别是多人研发时能确保安全。
但是事实上即便设置了属性，类内依旧可以访问字段，属性更像对类外操作的要求。
所以不开放set访问器（要保证赋值总是合法的，不能让外界无条件修改），只在方法内进行范围限制也合理


public bool Start(int RequiredProgress)
{
if (finishedProgress >= requiredProgress)
{
if (RequiredProgress < 0)
{
throw new ArgumentException("RequiredProgress must be positive.", nameof(Progress));
}
this.requiredProgress = RequiredProgress;
finishedProgress = 0;
}
else
{
return false;
}
num++;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Progress的序号，表明是第几个实例化的Progress（利用static），不是指第几次Start

return true;
}

public void Add(int addProgress)
{
finishedProgress += addProgress;
if (finishedProgress > requiredProgress)
{
finishedProgress = requiredProgress;
}
}

public void Sub(int subProgress)
{
finishedProgress -= subProgress;
if (finishedProgress < 0)
{
finishedProgress = 0;
}
}

public void Double()
{
finishedProgress *= 2;
if(finishedProgress > requiredProgress)
{
finishedProgress = requiredProgress;
}
}

public (int FinishedProgress, int RequiredProgress) GetProgress()
{
return (finishedProgress, requiredProgress);
}
}

/*
Expand Down Expand Up @@ -89,4 +151,4 @@ RequiredProgress must be positive. (Parameter 'Homework1.Progress')
(18, 18)
(19, 20)
*/
}
}