Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSharp_胡广义_无22 #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 58 additions & 0 deletions hw1/hw1/Program.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System;
using System.Reflection.Metadata;

namespace Homework1
{
Expand Down Expand Up @@ -60,6 +61,63 @@ public class Progress : IProgress
// 一个进度条
// 只允许修改Progress类中的代码
// 要求实现IProgress中的要求
public int num;
public int Num {
get=>num;set=>num=value;
Copy link
Owner

@shangfengh shangfengh Aug 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没有调用Num
不希望外界修改,应该删除set访问器

}
public int requiredProgress = 0;
public int RequiredProgress {
get => requiredProgress; set => requiredProgress = value;
}
public int finishedProgress = 0;
public int FinishedProgress {
get => finishedProgress; set => finishedProgress = value;
Copy link
Owner

@shangfengh shangfengh Aug 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

本意是希望能在set访问器里限制 FinishedProgress的范围的,特别是多人研发时能确保安全。
但是事实上即便设置了属性,类内依旧可以访问字段,属性更像对类外操作的要求。
所以不开放set访问器(要保证赋值总是合法的,不能让外界无条件修改),只在方法内进行范围限制也合理
这里应当直接删去set访问器

}
public bool Start(int x)
{
if(finishedProgress < requiredProgress)
{
return false;
}
else if(x < 0)
{
throw new Exception("RequiredProgress must be positive. (Parameter 'Homework1.Progress')");
}
else
{
finishedProgress = 0;
requiredProgress = x;
return true;
}
}
public void Add(int x)
{
finishedProgress += x;
if(finishedProgress > requiredProgress)
{
finishedProgress = requiredProgress;
}
}
public void Sub(int x)
{
finishedProgress -= x;
if(finishedProgress < 0)
{
finishedProgress = 0;
}
}
public void Double()
{
finishedProgress *= 2;
if(finishedProgress > requiredProgress)
{
finishedProgress = requiredProgress;
}
}
public (int FinishedProgress, int RequiredProgress) GetProgress()
{
return (finishedProgress, requiredProgress);
}
}

/*
Expand Down