Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submission for 47022315 #146

Open
wants to merge 8 commits into
base: topic-recognition
Choose a base branch
from

Conversation

carsonalh
Copy link

No description provided.

@shaivikaaaa
Copy link
Collaborator

@gayanku

@yexincheng
Copy link
Collaborator

This is an initial inspection, no action is required at this point

  1. Solves problem: No quantitative metrics were reported. No training logs or loss plots were recorded. From the presented prediction figures, it seems the model predicted nothing. Dependency requirement and reference were not written in the report.
  2. Implementation: The structures of functions and classes are good. But, no epochs such argument used, the training code only loop the dataset once. Learning rate and batch size are hard-coded
  3. Design: Good
  4. Comment: No comments at all.
  5. Difficulty: Easy

NOTE:
Your project should be created under PatternAnalysis-2024/recognition/<student_constructed_folder>, otherwise it won't be merged

@hanemma7moud hanemma7moud added the PDF PDF submitted label Nov 13, 2024
@gayanku
Copy link
Collaborator

gayanku commented Nov 14, 2024

Marking

Good/OK/Fair Practice (Design/Commenting, TF/Torch Usage)
No design and implementation. -2
Spacing and comments.
No Header blocks. -1
Recognition Problem
OK solution to problem. Model training evidance not present.-3
Driver Script present.
File structure present.
Good Usage & Demo & Visualisation & Data usage.
Module present.
Commenting missing. -1
No Data leakage found.
Difficulty : Easy. UNet2D (Easy Difficulty)-10
Commit Log
Some/Adequate Meaningful commit messages. -1
No Progressive commits. All on one day.-3
Documentation
Readme :Acceptable. Incomplete.-3
Model/technical explanation :Good.
Description and Comments :Acceptable. References missing.-1
Markdown used and PDF submitted. PDF checked.
Pull Request
Successful Pull Request (Working Algorithm Delivered on Time in Correct Branch). Submitted on time.
No Feedback required.
Request Description is good.
TOTAL-25

Marked as per the due date and changes after which aren't necessarily allowed to contribute to grade for fairness.
Subject to approval from Shakes

@gayanku gayanku added the Preliminary Grade To be confirmed after review. label Nov 14, 2024
@shakes76
Copy link
Owner

No evidence of working model -2, PR description missing -1

@shakes76 shakes76 added Completed Updated_Grade BB grade needs adjustment labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BB Completed PDF PDF submitted Preliminary Grade To be confirmed after review. _UNet2D Updated_Grade BB grade needs adjustment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants