-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow webpack-merge
v6
#502
Conversation
WalkthroughThis update focuses on enhancing the compatibility of the project with webpack-merge v6, ensuring that the project can use either v5.8.0 or v6.0.0 of the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
CHANGELOG.md (1)
15-15
: Fix the unordered list style.The unordered list style should use an asterisk instead of a dash.
- - Allow `webpack-merge` v6 to be used [PR 502](https://github.com/shakacode/shakapacker/pull/502) by [G-Rath](https://github.com/g-rath). + * Allow `webpack-merge` v6 to be used [PR 502](https://github.com/shakacode/shakapacker/pull/502) by [G-Rath](https://github.com/g-rath).Tools
Markdownlint
15-15: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- CHANGELOG.md (1 hunks)
- package.json (1 hunks)
Files skipped from review due to trivial changes (1)
- package.json
Additional context used
Markdownlint
CHANGELOG.md
14-14: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
15-15: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
Summary
v6 just changes the min. Node to v18, so it's fine to allow both versions to be used.
Pull Request checklist
Other Information
v6 originally changed what it used to do its cloning, but that was later reverted due to a subtle difference meaning the only impactful change is to the supported Node version
Summary by CodeRabbit
webpack-merge
dependency to support version 6.