Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow webpack-merge v6 #502

Merged
merged 2 commits into from
Jul 8, 2024
Merged

feat: allow webpack-merge v6 #502

merged 2 commits into from
Jul 8, 2024

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Jul 7, 2024

Summary

v6 just changes the min. Node to v18, so it's fine to allow both versions to be used.

Pull Request checklist

  • Add/update test to cover these changes
  • Update documentation
  • Update CHANGELOG file

Other Information

v6 originally changed what it used to do its cloning, but that was later reverted due to a subtle difference meaning the only impactful change is to the supported Node version

Summary by CodeRabbit

  • Chores
    • Updated webpack-merge dependency to support version 6.

Copy link

coderabbitai bot commented Jul 7, 2024

Walkthrough

This update focuses on enhancing the compatibility of the project with webpack-merge v6, ensuring that the project can use either v5.8.0 or v6.0.0 of the webpack-merge dependency. This improvement was applied without altering any exported or public entities.

Changes

File Summary of Changes
CHANGELOG.md Added a short summary mentioning the update to allow the use of webpack-merge v6.
package.json Updated the webpack-merge dependency to include ^6.0.0 alongside ^5.8.0.

Poem

🐇 Amid the code a small shift arose,
🌟 Compatibility glows, as the project grows.
Webpack-merge aligns, both old and new,
PR five zero two, a seamless view.
Dependencies now dance, in perfect synchrony,
An update so slight, yet crafted with glee. 🌱✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range and nitpick comments (1)
CHANGELOG.md (1)

15-15: Fix the unordered list style.

The unordered list style should use an asterisk instead of a dash.

- - Allow `webpack-merge` v6 to be used [PR 502](https://github.com/shakacode/shakapacker/pull/502) by [G-Rath](https://github.com/g-rath).
+ * Allow `webpack-merge` v6 to be used [PR 502](https://github.com/shakacode/shakapacker/pull/502) by [G-Rath](https://github.com/g-rath).
Tools
Markdownlint

15-15: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b60efcc and 29d8554.

Files selected for processing (2)
  • CHANGELOG.md (1 hunks)
  • package.json (1 hunks)
Files skipped from review due to trivial changes (1)
  • package.json
Additional context used
Markdownlint
CHANGELOG.md

14-14: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)


15-15: Expected: asterisk; Actual: dash
Unordered list style

(MD004, ul-style)

@justin808 justin808 merged commit 6df8ed6 into shakacode:main Jul 8, 2024
39 checks passed
@G-Rath G-Rath deleted the patch-1 branch July 8, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants